Return-Path: X-Original-To: apmail-deltacloud-dev-archive@www.apache.org Delivered-To: apmail-deltacloud-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2D94EDF73 for ; Mon, 19 Nov 2012 11:15:26 +0000 (UTC) Received: (qmail 38972 invoked by uid 500); 19 Nov 2012 11:15:25 -0000 Delivered-To: apmail-deltacloud-dev-archive@deltacloud.apache.org Received: (qmail 38944 invoked by uid 500); 19 Nov 2012 11:15:25 -0000 Mailing-List: contact dev-help@deltacloud.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@deltacloud.apache.org Delivered-To: mailing list dev@deltacloud.apache.org Received: (qmail 38925 invoked by uid 99); 19 Nov 2012 11:15:25 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 19 Nov 2012 11:15:25 +0000 X-ASF-Spam-Status: No, hits=-5.0 required=5.0 tests=RCVD_IN_DNSWL_HI,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of mandreou@redhat.com designates 209.132.183.28 as permitted sender) Received: from [209.132.183.28] (HELO mx1.redhat.com) (209.132.183.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 19 Nov 2012 11:15:18 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qAJBEvWh011248 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 19 Nov 2012 06:14:57 -0500 Received: from [10.36.112.23] (ovpn-112-23.ams2.redhat.com [10.36.112.23]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id qAJBEsc7013098; Mon, 19 Nov 2012 06:14:55 -0500 Message-ID: <50AA14AE.5070908@redhat.com> Date: Mon, 19 Nov 2012 13:14:54 +0200 From: "marios@redhat.com" User-Agent: Mozilla/5.0 (X11; Linux i686; rv:16.0) Gecko/20121029 Thunderbird/16.0.2 MIME-Version: 1.0 To: dev@deltacloud.apache.org CC: mfojtik@redhat.com Subject: Re: [PATCH core 2/2] EC2: Round down the float value of m2.xlarge hardware_profile (DTACLOUD-373) References: <1353319574-23512-1-git-send-email-mfojtik@redhat.com> <1353319574-23512-2-git-send-email-mfojtik@redhat.com> In-Reply-To: <1353319574-23512-2-git-send-email-mfojtik@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.67 on 10.5.11.11 X-Virus-Checked: Checked by ClamAV on apache.org NACK - as discussed on irc, i think we should fix this in the MachineConfiguration model (from_hardware_profile) rather than in ec2 driver. On 19/11/12 12:06, mfojtik@redhat.com wrote: > From: Michal Fojtik > > > Signed-off-by: Michal fojtik > --- > server/lib/deltacloud/drivers/ec2/ec2_driver.rb | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/server/lib/deltacloud/drivers/ec2/ec2_driver.rb b/server/lib/deltacloud/drivers/ec2/ec2_driver.rb > index c7bed05..a49d6f0 100644 > --- a/server/lib/deltacloud/drivers/ec2/ec2_driver.rb > +++ b/server/lib/deltacloud/drivers/ec2/ec2_driver.rb > @@ -98,7 +98,8 @@ module Deltacloud > end > > define_hardware_profile('m2.xlarge') do > - cpu 6.5 > + # 6.5 EC2 Compute Units (2 virtual cores with 3.25 EC2 Compute Units each) > + cpu 6 > memory 17.1 * 1024 > storage 420 > architecture 'x86_64' >