deltacloud-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michal Fojtik <mfoj...@redhat.com>
Subject Re: [PATCH core 2/4] CIMI: Initial implementation of $expand
Date Mon, 08 Oct 2012 10:33:04 GMT
On Oct 6, 2012, at 2:51 AM, David Lutterkort <lutter@redhat.com> wrote:

> Hi Michal,
> 
> On Wed, 2012-10-03 at 18:10 +0200, mfojtik@redhat.com wrote:
>> From: Michal Fojtik <mfojtik@redhat.com>
>> 
>> * This PoC works only for MachineCollection now (disks, volumes)
> 
> this finally forced me to finish the stuff I had done around embedded
> collections. I'll send out a patch series for that.
> 
> The stuff you did around $expand would still be usable, I think (after
> some serious rebasing ;)

Rebase complete :-) However I found few issues:

* http://localhost:3001/cimi/machines/inst0/disks -> return

, [2012-10-08T12:28:10.823334 #96183] ERROR -- : [500] NoMethodError:undefined method `default'
for CIMI::Model::DiskCollection:Class

/Users/mfojtik/code/core/server/lib/cimi/collections/machines.rb:126:in `block (3 levels)
in <class:Machines>'

* The collections are always expanded. I don't think this is the right behavior
  here. AFAIK the point of collections was to display just 'href' to resource
  and then expand details on those you want (with $expand + $filter combo).
  But having everything expanded by default makes this useless from client point
  of view and also from backend POV (DC need always to query backend for extra details).

  -- Michal

Michal Fojtik
http://deltacloud.org
mfojtik@redhat.com




Mime
View raw message