Return-Path: X-Original-To: apmail-deltacloud-dev-archive@www.apache.org Delivered-To: apmail-deltacloud-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E5D74DF99 for ; Tue, 11 Sep 2012 22:42:31 +0000 (UTC) Received: (qmail 50841 invoked by uid 500); 11 Sep 2012 22:42:31 -0000 Delivered-To: apmail-deltacloud-dev-archive@deltacloud.apache.org Received: (qmail 50821 invoked by uid 500); 11 Sep 2012 22:42:31 -0000 Mailing-List: contact dev-help@deltacloud.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@deltacloud.apache.org Delivered-To: mailing list dev@deltacloud.apache.org Received: (qmail 50811 invoked by uid 99); 11 Sep 2012 22:42:31 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 11 Sep 2012 22:42:31 +0000 X-ASF-Spam-Status: No, hits=-5.0 required=5.0 tests=RCVD_IN_DNSWL_HI,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of lutter@redhat.com designates 209.132.183.28 as permitted sender) Received: from [209.132.183.28] (HELO mx1.redhat.com) (209.132.183.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 11 Sep 2012 22:42:24 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q8BMg1Ql025787 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 11 Sep 2012 18:42:02 -0400 Received: from [10.3.112.66] (ovpn-112-66.phx2.redhat.com [10.3.112.66]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q8BMg1rY023218 for ; Tue, 11 Sep 2012 18:42:01 -0400 Message-ID: <1347403320.24304.4.camel@avon.watzmann.net> Subject: Re: [PATCH core] Core: Code layout fixes and avoiding duplication From: David Lutterkort To: dev@deltacloud.apache.org Date: Tue, 11 Sep 2012 15:42:00 -0700 In-Reply-To: <1347367740-30788-1-git-send-email-mfojtik@redhat.com> References: <1347367740-30788-1-git-send-email-mfojtik@redhat.com> Organization: Red Hat Inc Content-Type: text/plain; charset="ISO-8859-15" Content-Transfer-Encoding: 7bit Mime-Version: 1.0 X-Scanned-By: MIMEDefang 2.68 on 10.5.11.25 On Tue, 2012-09-11 at 14:49 +0200, mfojtik@redhat.com wrote: > From: Michal Fojtik > > * Moved '[CIMI|Deltacloud]::Base' class to base_collection.rb. > Having this Sinatra class in 'helpers.rb' is not very intuitive. Why not move it to {cimi,deltacloud}/collections/base.rb (rather than base_collection.rb) ? That's where I'd expect it to be given the class is {Deltacloud,CIMI}::Collections::Base David