deltacloud-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michal Fojtik <mfoj...@redhat.com>
Subject Re: [PATCH] Adds log_rule and rule_action for FirewallRule model - related to https://issues.apache.org/jira/browse/DTACLOUD-310
Date Mon, 03 Sep 2012 08:31:42 GMT
On Sep 3, 2012, at 9:04 AM, marios@redhat.com wrote:

ACK, there is one typo inline:

> From: marios <marios@redhat.com>
> 
> 
> Signed-off-by: marios <marios@redhat.com>
> ---
> server/lib/deltacloud/collections/firewalls.rb | 2 ++
> server/lib/deltacloud/models/firewall_rule.rb  | 3 ++-
> 2 files changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/server/lib/deltacloud/collections/firewalls.rb b/server/lib/deltacloud/collections/firewalls.rb
> index 603a62e..42dc4ad 100644
> --- a/server/lib/deltacloud/collections/firewalls.rb
> +++ b/server/lib/deltacloud/collections/firewalls.rb
> @@ -16,6 +16,8 @@
> module Deltacloud::Collections
>   class Firewalls < Base
> 
> +    include Deltacloud::Features
> +
>     set :capability, lambda { |m| driver.respond_to? m }
> 
>     check_features :for => lambda { |c, f| driver.class.has_feature?(c, f) }
> diff --git a/server/lib/deltacloud/models/firewall_rule.rb b/server/lib/deltacloud/models/firewall_rule.rb
> index 3959eb6..28834d0 100644
> --- a/server/lib/deltacloud/models/firewall_rule.rb
> +++ b/server/lib/deltacloud/models/firewall_rule.rb
> @@ -20,4 +20,5 @@ class FirewallRule < BaseModel
>   attr_accessor :port_to
>   attr_accessor :sources
>   attr_accessor :direction #ingress egress
> -end

^^ This -end causes: http://tracker.deltacloud.org/build/40/build

> +  attr_accessor :rule_action #Accept/Deny - initially added for FGCP
> +  attr_accessor :log_rule #log when rule triggered true/false - added for FGCP
> -- 
> 1.7.11.4
> 


Mime
View raw message