deltacloud-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From David Lutterkort <lut...@redhat.com>
Subject Re: [PATCH] Fix how deltacloud generally and openstack driver particularly checks supported_collections
Date Fri, 14 Sep 2012 19:42:44 GMT
On Fri, 2012-09-14 at 18:24 +0300, marios@redhat.com wrote:
> On 14/09/12 18:13, Michal Fojtik wrote:
> > On Sep 14, 2012, at 4:48 PM, marios@redhat.com wrote:
> > 
> > Looks good to me. There is one extra failure on OPTIONS in /api
> > so make sure you fix it before push :-)
> > 
>  yes thanks - I forgot to add the 'credentials' param to the call to
> 'supported_collections' for the OPTIONS route in server.rb.
> 
> > Also it would be nice if you can move that commented tests into
> > base_driver tests and run it just to make sure everything works
> > as expected.
> 
> sure - will have a go on monday.

Yes, this is much better. ACK from me after addressing Michal's
comments.

David



Mime
View raw message