Mailing-List: contact dev-help@deltacloud.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@deltacloud.apache.org
Received-SPF: pass (nike.apache.org: domain of mfojtik@redhat.com designates
 209.132.183.28 as permitted sender)
Content-Type: text/plain; charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 6.0 \(1485\))
Subject: Re: [PATCH 1/2] API TESTS: refactoring of common code - avoid
 duplication
From: Michal Fojtik <mfojtik@redhat.com>
In-Reply-To: <1344517364-7516-1-git-send-email-marios@redhat.com>
Date: Fri, 10 Aug 2012 15:04:13 +0200
Content-Transfer-Encoding: quoted-printable
Message-Id: <9B038E29-CEED-41CF-8920-2E152030C213@redhat.com>
References: <1344517364-7516-1-git-send-email-marios@redhat.com>
To: dev@deltacloud.apache.org

On Aug 9, 2012, at 3:02 PM, marios@redhat.com wrote:

ACK. Small nits inline.

> From: marios <marios@redhat.com>
>=20
>=20
> Signed-off-by: marios <marios@redhat.com>
> ---
> tests/README                       |   15 ++++----
> tests/config.yaml                  |   10 +++---
> tests/deltacloud/instances_test.rb |   63 =
+++++++++++-------------------------
> tests/deltacloud/test_setup.rb     |   27 +++++++++++----
> 4 files changed, 51 insertions(+), 64 deletions(-)
>=20
> diff --git a/tests/deltacloud/test_setup.rb =
b/tests/deltacloud/test_setup.rb
> index e034493..6beceb1 100644
> --- a/tests/deltacloud/test_setup.rb
> +++ b/tests/deltacloud/test_setup.rb
> @@ -43,6 +43,12 @@ class String
>     return self.gsub(/es$/, '') if self =3D~ /sses$/
>     self.gsub(/s$/, '')
>   end
> +  def pluralize
> +    return self + 'es' if self =3D~ /ess$/
> +    return self[0, self.length-1] + "ies" if self =3D~ /ty$/
> +    return self if self =3D~ /data$/
> +    self + "s"
> +  end
> end
>=20
> class Array

Why we need to have this in test_setup, when we already have core_ext
with pluralize() method ?

> @@ -83,12 +89,8 @@ module Deltacloud
>         @hash[driver]["bucket_locations"]
>       end
>=20
> -      def instances_config
> -        @hash[driver]["instances"] || {}
> -      end
> -
> -      def preferred_provider
> -        @hash[driver]["preferred_provider"]
> +      def preferred
> +        @hash[driver]["preferred"] || {}
>       end
>=20
>       def driver
> @@ -166,8 +168,8 @@ module Deltacloud::Test::Methods
>     end
>=20
>     def post(path, post_body, params=3D{})
> -      if api.preferred_provider and not params[:provider]
> -        params[:provider] =3D api.preferred_provider
> +      if api.preferred["provider"] and not params[:provider]
> +        params[:provider] =3D api.preferred["provider"]
>       end
>       url, headers =3D process_url_params(path, params)
>       RestClient.post url, post_body, headers
> @@ -204,6 +206,15 @@ module Deltacloud::Test::Methods
>       name.insert(0, "apitest")
>     end
>=20
> +    def get_a(item)
> +      if api.preferred[item]
> +        item_id =3D api.preferred[item]
> +      else
> +        item_list =3D get("/#{item.pluralize}")
> +        item_id =3D =
(item_list.xml/"#{item.pluralize}/#{item}").to_a.choice[:id]
> +      end
> +    end
> +
>     private
>=20
>     def process_url_params(path, params)
> --=20
> 1.7.6.5
>=20