Mailing-List: contact dev-help@deltacloud.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@deltacloud.apache.org
Received-SPF: pass (athena.apache.org: domain of mandreou@redhat.com
 designates 209.132.183.28 as permitted sender)
Message-ID: <501A329F.4020104@redhat.com>
Date: Thu, 02 Aug 2012 10:56:15 +0300
From: "marios@redhat.com" <mandreou@redhat.com>
User-Agent: Mozilla/5.0 (X11; Linux i686;
 rv:13.0) Gecko/20120605 Thunderbird/13.0
MIME-Version: 1.0
To: dev@deltacloud.apache.org
Subject: Re: [PATCH 2/2] API TESTS: adds images and instances tests
References: <1343821095-28813-1-git-send-email-marios@redhat.com>
  <1343821095-28813-2-git-send-email-marios@redhat.com>
 <1343866310.2653.55.camel@avon.watzmann.net>
In-Reply-To: <1343866310.2653.55.camel@avon.watzmann.net>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit

On 02/08/12 03:11, David Lutterkort wrote:
> On Wed, 2012-08-01 at 14:38 +0300, marios@redhat.com wrote:
>> From: marios <marios@redhat.com>
>>
>>
>> Signed-off-by: marios <marios@redhat.com>
>> ---
>>  tests/config.yaml                  |   19 ++-
>>  tests/deltacloud/base_api_test.rb  |    8 +-
>>  tests/deltacloud/images_test.rb    |   75 ++++++++
>>  tests/deltacloud/instances_test.rb |  353 ++++++++++++++++++++++++++++++++++++
>>  4 files changed, 448 insertions(+), 7 deletions(-)
> 
> When I run 'rake test:deltacloud' I get a failure in buckets_test.rb:200
> ("should be possible to GET blob data with
> GET /api/buckets/:id/blob/content") that kills my server and makes all
> subsequent tests die with Errno::ECONNREFUSED. The server dies with
> 'TypeError - can't modify frozen array:' with a very impressive
> stacktrace (attached)

yes, this is the GET blob content issue I was telling you about and
which we decided to put on ice until after the testing framework was
somewhat more complete. I guess I could just skip this test for now


> 
> Also, can we please not set t.options='-v' in the Rakefile ? People who
> want the extra verbiage can always pass TESTOPT="-v" to rake
> 
>> diff --git a/tests/deltacloud/base_api_test.rb b/tests/deltacloud/base_api_test.rb
>> index bd37b46..12e1e4d 100644
>> --- a/tests/deltacloud/base_api_test.rb
>> +++ b/tests/deltacloud/base_api_test.rb
>> @@ -120,17 +120,17 @@ describe "Deltacloud API Entry Point" do
>>    end
>>  
>>    it 'must change the API PROVIDER using the /api;provider matrix parameter in URI' do
>> -    res = get(';provider=test1', :public => true)
>> +    res = get("\;provider=test1", {:accept=>:xml, :noauth=>true})
> 
> Do we really need to escape the ';' in those strings ? Shouldn't be
> necessary.
> 
> David
>