deltacloud-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michal Fojtik <mfoj...@redhat.com>
Subject Re: [PATCH core 1/4] Core: Removed unused variables and trailing whitespace
Date Fri, 24 Aug 2012 09:53:33 GMT
On Aug 24, 2012, at 1:34 AM, David Lutterkort <lutter@redhat.com> wrote:

> I do have a comment on 2/4: there's a lot of talk about the importance
> of setting time in tests/drivers/gogrid/common.rb, but then the call to
> Time.be is commented out .. what gives ?

Sorry for that, I just copied the boiler plate from EC2 tests.
I freezed the time in each test, since GoGrid is strict in the timestamp
(I can't be older than 5 minutes), thus freezing the time in common is
not possible.

I removed that comments.

> Also, 'rake test:drivers:gogrid' fails with
> 
>          1) Failure:
>        test_0004_must allow to retrieve single hardware_profile(GoGrid Hardware Profiles)
[/homes/lutter/code/deltacloud/git/server/tests/drivers/gogrid/hardware_profiles_test.rb:46]:
>        Expected :memory (Symbol) to respond to #empty?.

Seems like an another funny MRI18 vs MRI19 issue:

In MRI18 this throw an exception:

:test.wont_be_empty

However it works under MRI19...

I fixed that by converting that symbol to String. That should work
on both platforms.

> ACK to the series once these two things are addressed.

Thanks. Corrected both and pushed :-)

  -- Michal

Michal Fojtik
http://deltacloud.org
mfojtik@redhat.com




Mime
View raw message