deltacloud-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From David Lutterkort <lut...@redhat.com>
Subject Re: [PATCH core 1/4] Core: Removed unused variables and trailing whitespace
Date Thu, 23 Aug 2012 23:34:24 GMT
On Thu, 2012-08-23 at 14:25 +0200, Michal Fojtik wrote:
> On Aug 23, 2012, at 2:18 PM, mfojtik@redhat.com wrote:
> 
> The 2/4 is obviously missing here, because the fixtures have >1MB.
> However you can use our new tool to download this set:
> 
> $ gem install tracker-client
> 
> Save this YAML to your ~/.trackerrc
> 
> ---
> :url: http://tracker.deltacloud.org/
> :user:
> :password:
> 
> Then you can do:
> 
> $ git checkout master
> $ tracker download 20 -b gogrid_tests

Very nice.

I do have a comment on 2/4: there's a lot of talk about the importance
of setting time in tests/drivers/gogrid/common.rb, but then the call to
Time.be is commented out .. what gives ?

Also, 'rake test:drivers:gogrid' fails with

          1) Failure:
        test_0004_must allow to retrieve single hardware_profile(GoGrid Hardware Profiles)
[/homes/lutter/code/deltacloud/git/server/tests/drivers/gogrid/hardware_profiles_test.rb:46]:
        Expected :memory (Symbol) to respond to #empty?.

ACK to the series once these two things are addressed.

David



Mime
View raw message