deltacloud-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From David Lutterkort <lut...@redhat.com>
Subject Re: [PATCH 1/4] API TESTS - moves common collections tests to separate module
Date Thu, 02 Aug 2012 22:11:09 GMT
On Thu, 2012-08-02 at 18:07 +0300, marios@redhat.com wrote:
> From: marios <marios@redhat.com>
> 
> 
> Signed-off-by: marios <marios@redhat.com>
> ---
>  tests/deltacloud/buckets_test.rb             |  134 ++++++++++----------------
>  tests/deltacloud/common_tests_collections.rb |  114 ++++++++++++++++++++++
>  tests/deltacloud/test_setup.rb               |   25 ++++-
>  3 files changed, 187 insertions(+), 86 deletions(-)
>  create mode 100644 tests/deltacloud/common_tests_collections.rb

Concerning those failures: the first seems to be a genuine mistake in
the test:

          1) Failure:
        test_0005_must have the instance_states element on top level(Deltacloud API ins
        tance_states collection) [/homes/lutter/code/deltacloud/git/tests/deltacloud/in
        stance_states_test.rb:49]: 
        Expected: "instance_states"
          Actual: "states"
        
.. there goes my clever plan of not duplicating common tests for
instance states. Seems they are just a one off.

There are four more failures (attached) that are all due to getting a
500 in instances_test.rb:84 from a GET /images - seems like there is
some genuine bug in the server code. Ran the server with
'./bin/deltacloudd -i mock' - the server log has no stacktrace, just a
line indicating that a status 500 was returned.

David


Mime
View raw message