deltacloud-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From David Lutterkort <lut...@redhat.com>
Subject Re: [PATCH 3/4] API TESTS: adds base tests for all collections - to be expanded
Date Thu, 02 Aug 2012 21:42:15 GMT
On Thu, 2012-08-02 at 18:07 +0300, marios@redhat.com wrote:
> From: marios <marios@redhat.com>
> 
> 
> Signed-off-by: marios <marios@redhat.com>
> ---
>  tests/deltacloud/hardware_profiles_test.rb |   28 +++++++++++++++
>  tests/deltacloud/instance_states_test.rb   |   52 ++++++++++++++++++++++++++++
>  tests/deltacloud/keys_test.rb              |   28 +++++++++++++++
>  tests/deltacloud/realms_test.rb            |   29 +++++++++++++++
>  tests/deltacloud/storage_snapshots_test.rb |   28 +++++++++++++++
>  tests/deltacloud/storage_volumes_test.rb   |   28 +++++++++++++++
>  6 files changed, 193 insertions(+), 0 deletions(-)

ACK

> diff --git a/tests/deltacloud/instance_states_test.rb b/tests/deltacloud/instance_states_test.rb
> index e69de29..d58d9ca 100644
> --- a/tests/deltacloud/instance_states_test.rb
> +++ b/tests/deltacloud/instance_states_test.rb
> @@ -0,0 +1,52 @@

These are a subset of CommonCollectionsTest::run_common_tests_for -
maybe they should be split into a separate method in
CommonCollectionsTest which can be called by both run_common_tests_for
and by this test suite. It seems the split is between common tests for
the collection and common tests for members of hte collection (whcih
instance_states does not have)

David



Mime
View raw message