deltacloud-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From David Lutterkort <lut...@redhat.com>
Subject Re: [PATCH 2/2] API TESTS: adds images and instances tests
Date Thu, 02 Aug 2012 00:11:50 GMT
On Wed, 2012-08-01 at 14:38 +0300, marios@redhat.com wrote:
> From: marios <marios@redhat.com>
> 
> 
> Signed-off-by: marios <marios@redhat.com>
> ---
>  tests/config.yaml                  |   19 ++-
>  tests/deltacloud/base_api_test.rb  |    8 +-
>  tests/deltacloud/images_test.rb    |   75 ++++++++
>  tests/deltacloud/instances_test.rb |  353 ++++++++++++++++++++++++++++++++++++
>  4 files changed, 448 insertions(+), 7 deletions(-)

When I run 'rake test:deltacloud' I get a failure in buckets_test.rb:200
("should be possible to GET blob data with
GET /api/buckets/:id/blob/content") that kills my server and makes all
subsequent tests die with Errno::ECONNREFUSED. The server dies with
'TypeError - can't modify frozen array:' with a very impressive
stacktrace (attached)

Also, can we please not set t.options='-v' in the Rakefile ? People who
want the extra verbiage can always pass TESTOPT="-v" to rake

> diff --git a/tests/deltacloud/base_api_test.rb b/tests/deltacloud/base_api_test.rb
> index bd37b46..12e1e4d 100644
> --- a/tests/deltacloud/base_api_test.rb
> +++ b/tests/deltacloud/base_api_test.rb
> @@ -120,17 +120,17 @@ describe "Deltacloud API Entry Point" do
>    end
>  
>    it 'must change the API PROVIDER using the /api;provider matrix parameter in URI'
do
> -    res = get(';provider=test1', :public => true)
> +    res = get("\;provider=test1", {:accept=>:xml, :noauth=>true})

Do we really need to escape the ';' in those strings ? Shouldn't be
necessary.

David


Mime
View raw message