deltacloud-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michal Fojtik (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DTACLOUD-288) New provider driver for Aruba cloud.it platform.
Date Tue, 31 Jul 2012 12:40:35 GMT

    [ https://issues.apache.org/jira/browse/DTACLOUD-288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13425715#comment-13425715
] 

Michal Fojtik commented on DTACLOUD-288:
----------------------------------------

Hi Aruba,

First, thanks for this contribution, I believe your driver will be nice addition to Deltacloud
API drivers. I have two very minor comments on your patch:

* I think you can safely remove the 'client = ' assignment in new_client.
* Some methods like 'images' or 'instances' are not wrapped by 'safely' block. Without that
blocks the 'exception do' will not work.

Otherwise ACK.

If you can re-sent the patch with this two minor things fixed, I will push it to GIT. Thanks!


                
> New provider driver for Aruba cloud.it platform.
> ------------------------------------------------
>
>                 Key: DTACLOUD-288
>                 URL: https://issues.apache.org/jira/browse/DTACLOUD-288
>             Project: DeltaCloud
>          Issue Type: New Feature
>          Components: Server
>            Reporter: Aruba Staff
>         Attachments: aruba_cloud_it_driver.patch
>
>
> Add the provider driver to manager Aruba cloud.it platform.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message