deltacloud-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michal Fojtik (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DTACLOUD-269) FGCP/mock: support metrics
Date Thu, 12 Jul 2012 09:53:33 GMT

    [ https://issues.apache.org/jira/browse/DTACLOUD-269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13412648#comment-13412648
] 

Michal Fojtik commented on DTACLOUD-269:
----------------------------------------

ACK both. 

One through for the 'mock' one:

You don't need to use @@ for the METRIC_NAMES constant. The '@@' sign is used for class-variables,
but the METRIC_NAMES is a constant not a variable. This has no implications or does not cause
any bug, just a coding style through.

Btw. the metrics for mock looks super awesome, thanks for contributing this. We should also
write couple tests for this into 'server/tests/drivers/mock'.
                
> FGCP/mock: support metrics
> --------------------------
>
>                 Key: DTACLOUD-269
>                 URL: https://issues.apache.org/jira/browse/DTACLOUD-269
>             Project: DeltaCloud
>          Issue Type: Improvement
>          Components: Server
>         Environment: FGCP and mock drivers
>            Reporter: Dies Koper
>            Priority: Minor
>         Attachments: 0001-mock-added-metrics-support.patch, 0002-FGCP-added-metrics-support.patch
>
>
> add support for metrics

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message