deltacloud-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From David Lutterkort <lut...@redhat.com>
Subject Re: [PATCH core 1/2] Core: Added tests for instances and hwp collections
Date Thu, 26 Jul 2012 22:46:43 GMT
On Thu, 2012-07-26 at 15:44 -0700, David Lutterkort wrote:
> On Thu, 2012-07-26 at 14:21 +0200, mfojtik@redhat.com wrote:
> > From: Michal Fojtik <mfojtik@redhat.com>
> > 
> > 
> > Signed-off-by: Michal fojtik <mfojtik@redhat.com>
> > ---
> >  .../hardware_profiles_collection_test.rb           |   51 +++++++++++++++++
> >  .../deltacloud/collections/keys_collection_test.rb |   60 ++++++++++++++++++++
> >  2 files changed, 111 insertions(+)
> >  create mode 100644 server/tests/deltacloud/collections/hardware_profiles_collection_test.rb
> >  create mode 100644 server/tests/deltacloud/collections/keys_collection_test.rb
> > 
> > diff --git a/server/tests/deltacloud/collections/hardware_profiles_collection_test.rb
b/server/tests/deltacloud/collections/hardware_profiles_collection_test.rb
> > new file mode 100644
> > index 0000000..6ba449a
> > --- /dev/null
> > +++ b/server/tests/deltacloud/collections/hardware_profiles_collection_test.rb
> > @@ -0,0 +1,51 @@
> > +require 'minitest/autorun'
> > +require_relative File.join('..', 'common.rb')
> 
> This fails on 1.8.7 - after applying my other patch series, put a
> "require 'require_relative'" in there and this gets my ACK.

Forgot to mention: the reason this is important is so that you can run
'bundle exec
ruby ./tests/deltacloud/collections/hardware_profiles_collection_test.rb' and the comment
applies to a lot of the other test files.

David



Mime
View raw message