deltacloud-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From David Lutterkort <lut...@redhat.com>
Subject Re: re-send: [PATCH core 4/7] Core: Added initial RHEV-M unit tests
Date Thu, 26 Jul 2012 21:46:36 GMT
On Thu, 2012-07-26 at 10:37 +0200, Michal Fojtik wrote:
> 
> ---
> Michal Fojtik, Sr. Soft. Engineer
> Deltacloud API / CloudForms
> mfojtik@redhat.com
> 
> On Jul 26, 2012, at 12:39 AM, David Lutterkort wrote:
> 
> > On Wed, 2012-07-25 at 16:42 +0200, Michal Fojtik wrote:
> >> Hi,
> >> 
> >> Seems like this patch is big for the list, so here you can grab it:
> >> 
> >> http://omicron.mifo.sk/0004-Core-Added-initial-RHEV-M-unit-tests.patch.gz
> > 
> > NAK because
> > 
> >      * this has user/password/provider hardwired in the code. It should
> >        get these from ~/.deltacloud/config (or complain if that doesn't
> >        exist)
> 
> I though that the server/tests/unit will not use this config (mean the tests should
> require nothing from user to configure). The user/password/provider is there just to
> record the VCR fixtures, then we're just replay-ing them without touching the provider.
> I don't expect somebody will try to run these unit tests against 'real' RHEV-M, I though
> Marios tests will be used in this case.

When people just run these tests, they won't need their own credentials;
but if they want to add to them, they'll also need to rerecord, in which
case credentials are needed.

The longer term solution should be what we discussed earlier on IRC:
      * only keep dummy credentials in the git repo; use these to run
        tests
      * when recording (the goal is to make it easy and safe for others
        to rerecord)
              * use proper 'live' credentials from
                ~/.deltacloud/config.yml for recording
              * replace Basic Auth headers in recorded data with headers
                based on dummy creds (since Basic Auth contains the
                username/password)
              * tell VCR to ignore other params/headers that are based
                on auth data, but don't contain the actual creds in any
                form (e.g., EC2's token)

For now, we can live with what we've been doing, though it's not very
friendly to others adding to the tests.

David



Mime
View raw message