deltacloud-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From David Lutterkort <lut...@redhat.com>
Subject Re: [PATCH core 1/7] RHEV-M: Fixed bug that cause instance not pick up image_id
Date Wed, 25 Jul 2012 22:31:41 GMT
On Wed, 2012-07-25 at 15:23 +0200, mfojtik@redhat.com wrote:
> From: Michal Fojtik <mfojtik@redhat.com>
> 
> 
> Signed-off-by: Michal fojtik <mfojtik@redhat.com>
> ---
>  server/lib/deltacloud/drivers/rhevm/rhevm_driver.rb |   13 +++++++++----
>  1 file changed, 9 insertions(+), 4 deletions(-)

ACK. It would be good if the commit message explained in more detail
what is being fixed here; something like the following in the body of
the commit message:

      * images: by convention, drivers return an empty array if
        opts[:id] is specified but no image with that id exists
      * create_instance: fix typo
      * convert_image: image state needs to be uppercase

The last point raises the question of whether we shouldn't map RHEV-M
image states to a fixed set of DC image states ...

David



Mime
View raw message