deltacloud-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From David Lutterkort <lut...@redhat.com>
Subject Re: [PATCH core 3/7] Core: Added X-Deltacloud-Provider and X-Deltacloud-Driver header to HTTP response
Date Thu, 19 Jul 2012 22:39:16 GMT
On Wed, 2012-07-18 at 18:03 +0200, mfojtik@redhat.com wrote:
> From: Michal Fojtik <mfojtik@redhat.com>
> 
> 
> Signed-off-by: Michal fojtik <mfojtik@redhat.com>
> ---
>  server/lib/deltacloud/helpers.rb |    4 ++++
>  1 file changed, 4 insertions(+)

ACK; the first line of the commit message is too long though, and the
commit message needs to explain why this change was made.

And while we are on the subject of testing: where is the test that
checks these headers are set properly ?

David



Mime
View raw message