deltacloud-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From David Lutterkort <lut...@redhat.com>
Subject Re: Initial server API tests (server/tests)
Date Tue, 17 Jul 2012 22:15:21 GMT
On Tue, 2012-07-17 at 16:00 +0200, mfojtik@redhat.com wrote:
> Hi,
> 
> This patch is just a first draft of upcoming server API tests revamp.
> 
> Tests included in this patch addresses:
> 
> 1. base_driver tests (features/constraints/hardware_profiles/instance_states DSL)
> 2. server/lib/deltacloud/models/*.rb tests (for those who define some additional
>    functionality)
> 
> I also found some small nits in models, like obsoleted helpers...

ACK, with a few minor nits:

      * 3/4 misses a mention of to_hash in
        lib/deltacloud/models/bucket.rb, line 23
      * Patches 1/4 and 2/4 should be swapped in the order of patches
        (and current 2/4 has a commit message that is too long)

David



Mime
View raw message