deltacloud-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Francesco Vollero <razor...@gmail.com>
Subject Re: [PATCH] allow multiple mock provider accounts
Date Thu, 07 Jun 2012 23:30:35 GMT
Hi Dave,

On Thu, Jun 7, 2012 at 6:24 PM, Dave Johnson <dajo@redhat.com> wrote:
> Ultimately needed for some unrelated conductor QE testing

Nack.
I would expect a more deeper description in order to accept it.
Why you would like to have an user like mockuser01 or such things ?
You can please also cite the Bugzilla or Redmine for conductor so we
can figure out the real purpose of this patch ?
Moreover, if you modify this line you should also write/fix the tests.

Cheers,
Francesco

> ---
>  server/lib/deltacloud/drivers/mock/mock_driver.rb |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/server/lib/deltacloud/drivers/mock/mock_driver.rb b/server/lib/deltacloud/drivers/mock/mock_driver.rb
> index ba817c6..cce4f48 100644
> --- a/server/lib/deltacloud/drivers/mock/mock_driver.rb
> +++ b/server/lib/deltacloud/drivers/mock/mock_driver.rb
> @@ -460,7 +460,7 @@ module Deltacloud::Drivers::Mock
>
>     def check_credentials(credentials)
>       safely do
> -        if ( credentials.user != 'mockuser' ) or ( credentials.password != 'mockpassword'
)
> +        if ( ! credentials.user.include? 'mockuser' ) or ( ! credentials.password.include?
'mockpassword' )
>           raise 'AuthFailure'
>         end
>       end
> --
> 1.7.7.6
>

Mime
View raw message