deltacloud-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "marios@redhat.com" <mandr...@redhat.com>
Subject Re: [PATCH core 1/3] EC2: Added X-Deltacloud-Driver and X-Deltacloud-Provider to HTTP response headers
Date Thu, 07 Jun 2012 08:52:45 GMT
nack - patches apply fine; need to add 'nokogiri-diff' to the .gemspec

I got 2 errors from tests; trace:

# On branch Michal_EC2_Frontend_Tests
nothing to commit (working directory clean)
[marios@name server]$ rake test:aws
NOTE: Gem::Specification#has_rdoc= is deprecated with no replacement. It
will be removed on or after 2011-10-01.
Gem::Specification#has_rdoc= called from deltacloud-core.gemspec:67
.
/usr/bin/ruby -I"lib" -I"/usr/lib/ruby/gems/1.8/gems/rake-0.9.2.2/lib"
"/usr/lib/ruby/gems/1.8/gems/rake-0.9.2.2/lib/rake/rake_test_loader.rb"
"tests/ec2/entrypoint_test.rb" "tests/ec2/actions_test.rb"
Run options: --seed 54138

# Running tests:

F....F......

Finished tests in 0.000000s, inf tests/s, inf assertions/s.

  1) Failure:
test_0004_should_return_list_of_instances_as_instancesresponse(Deltacloud EC2
frontend actions)
[/home/marios/Documents/WORK/NewEclipsey/DCore/deltacloud_git_repo/deltacloud/server/tests/ec2/actions_test.rb:31]:
Expected ["- Wed Jun 06 15:15:14 +0200 2012 /*/*[2]/*/*[4]/*[1]/*[4]",
"+ Wed Jun 06 16:15:14 +0300 2012 /*/*[2]/*/*[4]/*[1]/*[4]", "- Wed Jun
06 15:15:14 +0200 2012 /*/*[2]/*/*[4]/*[2]/*[4]", "+ Wed Jun 06 16:15:14
+0300 2012 /*/*[2]/*/*[4]/*[2]/*[4]"] to be empty.

  2) Failure:
test_0006_should_create_and_destroy_a_new_instance_using_the_runinstances(Deltacloud
EC2 frontend actions)
[/home/marios/Documents/WORK/NewEclipsey/DCore/deltacloud_git_repo/deltacloud/server/tests/ec2/actions_test.rb:45]:
Expected ["- Wed Jun 06 15:15:14 +0200 2012 /*/*[5]/*/*[4]", "+ Wed Jun
06 16:15:14 +0300 2012 /*/*[5]/*/*[4]"] to be empty.

12 tests, 28 assertions, 2 failures, 0 errors, 0 skips
rake aborted!
Command failed with status (1): [/usr/bin/ruby -I"lib"
-I"/usr/lib/ruby/gem...]

Tasks: TOP => test:aws
(See full trace by running task with --trace)
[marios@name server]$



On 06/06/12 16:48, mfojtik@redhat.com wrote:
> From: Michal Fojtik <mfojtik@redhat.com>
> 
> 
> Signed-off-by: Michal fojtik <mfojtik@redhat.com>
> ---
>  server/lib/ec2/server.rb |    2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/server/lib/ec2/server.rb b/server/lib/ec2/server.rb
> index 9b045e4..c8bf889 100644
> --- a/server/lib/ec2/server.rb
> +++ b/server/lib/ec2/server.rb
> @@ -53,6 +53,8 @@ module Deltacloud::EC2
>  
>      after do
>        headers 'Server' => 'Apache-Deltacloud-EC2/' + settings.version
> +      headers 'X-Deltacloud-Driver' => driver_symbol.to_s
> +      headers 'X-Deltacloud-Provider' => Thread.current[:provider] || ENV['API_PROVIDER']
|| 'default'
>      end
>  
>      get '/' do


Mime
View raw message