deltacloud-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michal Fojtik <mfoj...@redhat.com>
Subject Re: [jira] [Reopened] (DTACLOUD-216) exception when using 'run command' in GUI on an instance with no public ip
Date Fri, 25 May 2012 07:39:24 GMT
On 05/25/12, Koper, Dies wrote:
> Hi Michal,
> 
> It doesn't seem to be working for me. I did a git pull, quite sure this time that I don't
have any stray commits on master, started the server and get the following error when accessing
an instance page:

I'm sorry this looks like a typo. I fixed it and it should now work.

  -- Michal

> 
> SyntaxError - compile error
> ./lib/deltacloud/./../../views/instances/show.html.haml:63: syntax error, unexpected
':', expecting ')'
> ...es/%s/run', % @instance.id), :get
>                               ^:
>         ./lib/deltacloud/./../../views/instances/show.html.haml:72:in `evaluate_source'
>         D:/programs/Ruby187/lib/ruby/gems/1.8/gems/tilt-1.3.3/lib/tilt/template.rb:144:in
`cached_evaluate'
> 
> Regards,
> Dies Koper
> 
> > -----Original Message-----
> > From: Michal Fojtik [mailto:mfojtik@redhat.com]
> > Sent: Friday, 25 May 2012 12:08 AM
> > To: dev@deltacloud.apache.org
> > Subject: Re: [jira] [Reopened] (DTACLOUD-216) exception when using 'run
> > command' in GUI on an instance with no public ip
> > 
> > On 05/24/12, Koper, Dies wrote:
> > > Hi Michal,
> > >
> > > I'm replying by e-mail as I can't seem to access JIRA a.t.m.
> > >
> > > The issue is not with the run action itself, but the page that should be
> > displayed when clicking on 'run command', the page where the user can
> > type the command name.
> > > In my patch in haml I used
> > "#{run_instance_url(@instance.id)};id=#{@instance.id}". I don't remember
> > how I got it and whether it's correct, but it worked at the time.
> > 
> > Hi,
> > 
> > Sorry for this, seems like I overseen that action when I was moving the
> > code. It should be now fixed and all working from this commit:
> > 
> > commit 4954fb82bd99f994a2d4c0fe4227f52f519221b9
> > Author: Michal Fojtik <mfojtik@redhat.com>
> > Date:   Thu May 24 16:05:03 2012 +0200
> > 
> >     Core: Fixed run_on_instance view and wrong capability checking
> > 
> > I also added runner to your driver and fixed all the routes in views.
> > As a bonus :-) I fixed the :run action view, so now it fit to overal
> > layout.
> > 
> > Please let me know if you find any other inconsistencies like this, ussualy
> > they are easely fixable.
> > 
> >   -- Michal
> > 
> > >
> > > Regards,
> > > Dies Koper
> > >
> > >
> > > > -----Original Message-----
> > > > From: Michal Fojtik [mailto:mfojtik@redhat.com]
> > > > Sent: Thursday, 24 May 2012 5:53 PM
> > > > To: dev@deltacloud.apache.org
> > > > Subject: Re: [jira] [Reopened] (DTACLOUD-216) exception when using
> > 'run
> > > > command' in GUI on an instance with no public ip
> > > >
> > > > On 05/24/12, Dies Koper (JIRA) wrote:
> > > > >
> > > > >      [ https://issues.apache.org/jira/browse/DTACLOUD-
> > > > 216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
> > > > >
> > > > > Dies Koper reopened DTACLOUD-216:
> > > > > ---------------------------------
> > > > >
> > > > >
> > > > > The patch I submitted worked perfectly fine at the time. Now that
> > you've
> > > > merged it in, I get an error when I click on the run command button:
> > > > >
> > > > > http://localhost:3001/api/run_instances/inst1;id=inst1
> > > > > Sinatra doesn’t know this ditty.
> > > > >
> > > > > Fails both on mock driver and fgcp driver.
> > > > >
> > > > > Maybe something in the modular patches changed the url and broke
> > it?
> > > >
> > > > The URL should be:
> > > >
> > > > POST /api/instances/:instance_id/run
> > > >
> > > > You should sent 'cmd' in POST parameters.
> > > >
> > > >   -- Michal
> > > >
> > > > >
> > > > > > exception when using 'run command' in GUI on an instance with
no
> > > > public ip
> > > > > > --------------------------------------------------------------------------
> > > > > >
> > > > > >                 Key: DTACLOUD-216
> > > > > >                 URL: https://issues.apache.org/jira/browse/DTACLOUD-
> > 216
> > > > > >             Project: DeltaCloud
> > > > > >          Issue Type: Bug
> > > > > >          Components: Server
> > > > > >            Reporter: Dies Koper
> > > > > >            Assignee: Michal Fojtik
> > > > > >            Priority: Minor
> > > > > >         Attachments: 0005-allow-user-to-chose-target-ip-for-
> > > > run_on_instance.patch
> > > > > >
> > > > > >
> > > > > > Looking at the code, this applies to all drivers that support
the
> > > > run_on_instance operation.
> > > > > > The error is: undefined method `address' for nil:NilClass
> > > > > > I'd like to suggest we add a selection box to the GUI to display
all
> > public
> > > > and private (DC could be running on a VM in the same network after all)
> > IP
> > > > addresses of the VM so the user can chose. That should also prevent
> > this
> > > > error.
> > > > >
> > > > > --
> > > > > This message is automatically generated by JIRA.
> > > > > If you think it was sent incorrectly, please contact your JIRA
> > > > administrators:
> > > >
> > https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
> > > > > For more information on JIRA, see:
> > > > http://www.atlassian.com/software/jira
> > > > >
> > > > >
> > > >
> > > > --
> > > > Michal Fojtik
> > > > Sr. Software Engineer, Deltacloud API (http://deltacloud.org)
> > >
> > 
> > --
> > Michal Fojtik
> > Sr. Software Engineer, Deltacloud API (http://deltacloud.org)
> 

-- 
Michal Fojtik
Sr. Software Engineer, Deltacloud API (http://deltacloud.org)

Mime
View raw message