deltacloud-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michal Fojtik <mfoj...@redhat.com>
Subject Re: [PATCH core 01/32] Core: Added sinatra-rabbit gem to gemspec
Date Fri, 11 May 2012 12:30:27 GMT
On 05/11/12, Michal Fojtik wrote:

Just a quick note. Seems like the dragons blow up my github
'deltacloud_modular' branch and I cannot rebase against master anymore.
GIT is trying to apply all patches twice, which lead to infinite fun with
resolving conflicts.

I created a new branch called 'modular' on github[1]. Please switch to
using this branch. Sorry for this :-)


  -- Michal


> m/ruby/1.8/gems/cucumber-1.1.4/bin/../lib/cucumber/formatter/io.rb:7:in `initialize'
> >
> 
> The Cucumber tests should be launched from the 'server' directory:
> 
> firefly ~/code/core/server $ rake cucumber:mock:test
> ...........
> 41 scenarios (41 passed)
> 292 steps (292 passed)
> 0m10.489s
> 
> Note that I just fixed the Mock Cucumber suite, still working on EC2 one,
> but I assume since there were no changes to EC2 driver they will just work.
> 
> > To commit these, we need to get to a state where all the tests pass;
> > that's the biggest blocker right now.
> 
> Agree, I'll do that as high priority. Btw. I suggest to replace the 'mock'
> unit tests we have in server/tests/drivers/mock with the 'api' tests. They
> are doing the same thing now and the 'api' tests are more up-to-date.
> What do you think?
> 
> > Also, to make the patch series a little less daunting, you might
> > consider splitting patches that aren't directly related to modularizing
> > DC out (e.g., 14/32 or 30-32/32) This will make it much easier to review
> > them and get them committed separately.
> 
> Yeah, should I do that and send a new patch bomb? I can do it when rebasing
> against master when pushing but that will not be anyhow usefull for review
> ;-)
> 
> 
>   -- michal
> 
> -- 
> Michal Fojtik
> Sr. Software Engineer, Deltacloud API (http://deltacloud.org)

-- 
Michal Fojtik
Sr. Software Engineer, Deltacloud API (http://deltacloud.org)

Mime
View raw message