deltacloud-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hugh O. Brock" <hbr...@redhat.com>
Subject Re: [PATCH core] RHEV-M: Fixes instances to have SPICE enabled by default
Date Wed, 02 May 2012 16:34:34 GMT
On Wed, May 02, 2012 at 03:47:38PM +0200, mfojtik@redhat.com wrote:
> From: Michal Fojtik <mfojtik@redhat.com>
> 
> 
> Signed-off-by: Michal fojtik <mfojtik@redhat.com>
> ---
>  server/lib/deltacloud/drivers/rhevm/rhevm_driver.rb |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/server/lib/deltacloud/drivers/rhevm/rhevm_driver.rb b/server/lib/deltacloud/drivers/rhevm/rhevm_driver.rb
> index 1c96df7..9e8dcc4 100644
> --- a/server/lib/deltacloud/drivers/rhevm/rhevm_driver.rb
> +++ b/server/lib/deltacloud/drivers/rhevm/rhevm_driver.rb
> @@ -190,6 +190,7 @@ class RHEVMDriver < Deltacloud::BaseDriver
>        params[:cores] = opts[:hwp_cpu] if opts[:hwp_cpu]
>        params[:user_data] = opts[:user_data].gsub(/\n/,'') if opts[:user_data]
>        params[:fileinject_path] = "deltacloud-user-data.txt"
> +      params[:display] = 'spice'
>        convert_instance(client, client.create_vm(params))
>      end
>    end
> -- 

Michal, I don't know if it's reasonable to have params[:display]
always set to 'spice', do you? What would happen in the event the user
didn't have a spice client available?

Also: Is there a workaround for customers with existing CloudForms
installations? It's way too late for code changes for the 1.0 release.

Take care,
--Hugh

-- 
== Hugh Brock, hbrock@redhat.com                                   ==
== Engineering Manager, Cloud BU                                   ==
== Aeolus Project: Manage virtual infrastructure across clouds.    ==
== http://aeolusproject.org                                        ==

"I know that you believe you understand what you think I said, but I’m
not sure you realize that what you heard is not what I meant."
--Robert McCloskey

Mime
View raw message