deltacloud-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From David Lutterkort <lut...@redhat.com>
Subject Re: [PATCH core 03/32] Core: Added wrapper for autoloading collections
Date Thu, 10 May 2012 18:43:01 GMT
On Thu, 2012-05-10 at 10:25 +0200, Michal Fojtik wrote:
> On 05/10/12, David Lutterkort wrote:
> > On Tue, 2012-04-17 at 15:39 +0200, mfojtik@redhat.com wrote:
> > > From: Michal Fojtik <mfojtik@redhat.com>
> > 
> > [ I am looking at your branch, but it's more convenient to reply to
> > individual patches ]
> > 
> > This and 2/32 seem like a little too much magic to me; why do this
> > rather than have a big server.rb ? It's 1200 lines right now, but they
> > are fairly boring code, and I like being able to see all that code at
> > once.
> 
> Sorry, I was too fast with replying ;-) You are referring to the collection
> subfolder not to lazy-loading.
> 
> My thoughts was to make it more readable and structured when it will be
> splitted into separate files.

After looking at it again, I am fine with splitting it across multiple
files; I mostly object to the lazy-loading stuff. IMHO, it makes the
code less readable: when I open collection.rb, I expect to see a bunch
of 'require' statements and not much else; instead I need to actually
read through the code now and figure out that it essentially does what
the require's would do.

And having explicit 'use' in server.rb would make things more readable,
too.

David



Mime
View raw message