Return-Path: X-Original-To: apmail-deltacloud-dev-archive@www.apache.org Delivered-To: apmail-deltacloud-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7FED49028 for ; Fri, 24 Feb 2012 12:29:06 +0000 (UTC) Received: (qmail 81287 invoked by uid 500); 24 Feb 2012 12:29:06 -0000 Delivered-To: apmail-deltacloud-dev-archive@deltacloud.apache.org Received: (qmail 81260 invoked by uid 500); 24 Feb 2012 12:29:06 -0000 Mailing-List: contact dev-help@deltacloud.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@deltacloud.apache.org Delivered-To: mailing list dev@deltacloud.apache.org Received: (qmail 81252 invoked by uid 99); 24 Feb 2012 12:29:06 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 24 Feb 2012 12:29:06 +0000 X-ASF-Spam-Status: No, hits=-5.0 required=5.0 tests=RCVD_IN_DNSWL_HI,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of fvollero@redhat.com designates 209.132.183.28 as permitted sender) Received: from [209.132.183.28] (HELO mx1.redhat.com) (209.132.183.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 24 Feb 2012 12:28:58 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q1OCSbnI019185 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 24 Feb 2012 07:28:37 -0500 Received: from dhcp-2-158.brq.redhat.com (dhcp-2-158.brq.redhat.com [10.34.2.158]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q1OCSYBU024839 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO) for ; Fri, 24 Feb 2012 07:28:36 -0500 Date: Fri, 24 Feb 2012 13:28:34 +0100 From: Francesco Vollero To: dev@deltacloud.apache.org Subject: Re: [PATCH core 3/3] RHEV-M: Report 404 correctly on unknown datacenter Message-ID: <20120224122833.GD27787@dhcp-2-158.brq.redhat.com> References: <1330086199-89449-1-git-send-email-mfojtik@redhat.com> <1330086199-89449-3-git-send-email-mfojtik@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1330086199-89449-3-git-send-email-mfojtik@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Scanned-By: MIMEDefang 2.68 on 10.5.11.25 X-Virus-Checked: Checked by ClamAV on apache.org Ack'd Cheers, Francesco On Fri, Feb 24, 2012 at 01:23:19PM +0100, mfojtik@redhat.com wrote: > From: Michal Fojtik > > > Signed-off-by: Michal fojtik > --- > .../lib/deltacloud/drivers/rhevm/rhevm_driver.rb | 12 ++++-------- > 1 files changed, 4 insertions(+), 8 deletions(-) > > diff --git a/server/lib/deltacloud/drivers/rhevm/rhevm_driver.rb b/server/lib/deltacloud/drivers/rhevm/rhevm_driver.rb > index 162175c..10ffef3 100644 > --- a/server/lib/deltacloud/drivers/rhevm/rhevm_driver.rb > +++ b/server/lib/deltacloud/drivers/rhevm/rhevm_driver.rb > @@ -335,20 +335,16 @@ class RHEVMDriver < Deltacloud::BaseDriver > status 401 > end > > - on /ResourceNotFound/ do > - status 404 > - end > - > on /(InternalServerError|nodename nor servname provided)/ do > status 502 > end > > - on /(RestClient|RHEVM|Ovirt)/ do > - status 500 > + on /(404|ResourceNotFound)/ do > + status 404 > end > > - on /(.*) not found^/ do > - status 400 > + on /(RestClient|RHEVM|OVIRT)/ do > + status 500 > end > > on /Parameter name/ do > -- > 1.7.9.1 >