deltacloud-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From David Lutterkort <lut...@redhat.com>
Subject Re: Blob creation
Date Thu, 18 Aug 2011 21:13:24 GMT
On Thu, 2011-08-18 at 11:07 +0300, marios@redhat.com wrote:
> The name change for the parameter was, I can only guess, some attempt to 
> maintain consistency (i.e. 'blob' over 'blob_id') though in hindsight 
> was not really necessary. Your suggested patch:
> 
> 
> post "#{Sinatra::UrlForHelper::DEFAULT_URI_PREFIX}/buckets/:bucket" do
>     bucket_id = params[:bucket]
> -  blob_id = params['blob']
> +  blob_id = params['blob'] || params['blob_id']
> 
> seems fine to me in that it won't break anything. If it maintains 
> compatibility with your stuff then I personally have no objection to 
> making this addition. More on PUT vs POST below

Since going from blob_id to blob is API breakage, our docs etc. should
only mention blob_id, and we should remove accepting a blob param
alltogether.

David



Mime
View raw message