deltacloud-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From David Lutterkort <lut...@redhat.com>
Subject Re: [PATCH core] Added destroy method for image for VSphere and EC2
Date Wed, 13 Jul 2011 21:19:40 GMT
On Wed, 2011-07-13 at 12:04 +0200, mfojtik@redhat.com wrote:
> From: Michal Fojtik <mfojtik@redhat.com>
> 
> 
> Signed-off-by: Michal fojtik <mfojtik@redhat.com>

ACK. One nit:

> diff --git a/server/lib/deltacloud/drivers/vsphere/vsphere_driver.rb b/server/lib/deltacloud/drivers/vsphere/vsphere_driver.rb
> index 64bfa34..81b5a85 100644
> --- a/server/lib/deltacloud/drivers/vsphere/vsphere_driver.rb
> +++ b/server/lib/deltacloud/drivers/vsphere/vsphere_driver.rb
> @@ -257,9 +257,12 @@ module Deltacloud::Drivers::VSphere
>      # Destroy an instance, given its id. Note that this will destory all
>      # instance data.
>      def destroy_instance(credentials, id)
> +      id = id[:id] if id.class == Hash

We should have one calling convention for this - either always pass in a
hash or always pass in just the id.

David



Mime
View raw message