deltacloud-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sang-Min Park <sp...@eucalyptus.com>
Subject RE: [PATCH] Patch in preparation for eucalyptus driver
Date Wed, 23 Mar 2011 23:31:08 GMT
Hmm, maybe I misunderstood something.
Yes, it is a repost of the previous patch.

Did you send comments on that patch before?
I saw the comments for the other patch ([PATCH] Eucalyptus driver
support), but not for this one ([PATCH] Patch in preparation for
eucalyptus driver).


Sang-min

-----Original Message-----
From: David Lutterkort [mailto:lutter@redhat.com]
Sent: Wednesday, March 23, 2011 4:18 PM
To: deltacloud-dev@incubator.apache.org
Cc: Sang-Min Park
Subject: Re: [PATCH] Patch in preparation for eucalyptus driver

On Tue, 2011-03-22 at 10:16 -0700, sang-min.park@eucalyptus.com wrote:
> From: Sang-Min Park <spark@eucalyptus.com>
>
> ---
>  server/lib/deltacloud/base_driver/base_driver.rb |   25 +++++++---
>  server/lib/deltacloud/base_driver/features.rb    |    9 +++
>  server/lib/deltacloud/drivers/ec2/ec2_driver.rb  |   59
+++++++++++++--------
>  server/lib/deltacloud/validation.rb              |    5 ++
>  4 files changed, 68 insertions(+), 30 deletions(-)

This seems to simply be a repost of your original patch, and doesn't
address any of the comments I made.

In particular, there should not be any need to do anything special for
hardware_profiles and features, since they are not inherited anymore;
rather each driver class has its own list of these.

David

Mime
View raw message