deltacloud-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From David Lutterkort <lut...@redhat.com>
Subject Re: [PATCH core 1/2] Added Image creation from Instances (EC2, Mock, GoGrid, Rackspace)
Date Sat, 05 Mar 2011 00:31:23 GMT
On Fri, 2011-03-04 at 13:15 +0100, mfojtik@redhat.com wrote:
> From: Michal Fojtik <mfojtik@redhat.com>
> 
> ---
>  server/lib/deltacloud/drivers/ec2/ec2_driver.rb    |   13 +++++++-
>  .../lib/deltacloud/drivers/gogrid/gogrid_driver.rb |    3 +-
>  .../drivers/mock/data/instances/inst0.yml          |    1 +
>  .../drivers/mock/data/instances/inst1.yml          |    1 +
>  .../drivers/mock/data/instances/inst2.yml          |    1 +
>  server/lib/deltacloud/drivers/mock/mock_driver.rb  |   28 ++++++++++++++++
>  .../drivers/rackspace/rackspace_driver.rb          |   34 ++++++++++----------
>  .../lib/deltacloud/helpers/application_helper.rb   |   28 ++++++++++++++++
>  server/lib/deltacloud/models/instance.rb           |    5 +++
>  server/server.rb                                   |   26 +++++++++++++++
>  server/views/images/new.html.haml                  |   14 ++++++++
>  server/views/images/show.xml.haml                  |    3 ++
>  server/views/instances/show.html.haml              |    5 +++
>  server/views/instances/show.xml.haml               |    6 +++
>  14 files changed, 149 insertions(+), 19 deletions(-)
>  create mode 100644 server/views/images/new.html.haml

NAK - solely because I don't want to start advertising optional params
with this patch. Without the use of generate_action_params I'd be
perfectly happy with this.

David



Mime
View raw message