deltacloud-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michal Fojtik <mfoj...@redhat.com>
Subject Re: [PATCH core 1/3] Added warning for unhandled exception. This will show just 'visible' message to developer, that he needs to 'catch' this exception and display it as an XML error to client instead of throwing that exception to system log.
Date Tue, 07 Dec 2010 15:06:07 GMT
On 07/12/10 16:12 +0200, marios@redhat.com wrote:
>ack to all 3,

Thanks for review!. Pushing to master.

  -- Michal

>
>apply fine and all working ok. Only just noticed the 
>'catched_exception_list' mechanism, this is very nice - didn't 
>realise we could define these per driver (i think so far we only have 
>this for ec2).
>
>marios
>On 07/12/10 13:40, mfojtik@redhat.com wrote:
>>From: Michal Fojtik<mfojtik@redhat.com>
>>
>>---
>>  server/lib/deltacloud/base_driver/base_driver.rb |    3 +++
>>  1 files changed, 3 insertions(+), 0 deletions(-)
>>
>>diff --git a/server/lib/deltacloud/base_driver/base_driver.rb b/server/lib/deltacloud/base_driver/base_driver.rb
>>index 4419359..ebd2078 100644
>>--- a/server/lib/deltacloud/base_driver/base_driver.rb
>>+++ b/server/lib/deltacloud/base_driver/base_driver.rb
>>@@ -256,6 +256,9 @@ module Deltacloud
>>          catched_exceptions_list[:glob].each do |ex|
>>            raise Deltacloud::BackendError.new(502, e.class.to_s, e.message, e.backtrace)
if e.class.name =~ ex
>>          end
>>+        puts "======= UNHANDLED EXCEPTION ============"
>>+        puts e.inspect
>>+        puts "========================================"
>>          raise e
>>        end
>>      end
>

-- 
--------------------------------------------------------
Michal Fojtik, mfojtik@redhat.com
Deltacloud API: http://deltacloud.org
--------------------------------------------------------

Mime
View raw message