db-torque-user mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Peter Frühberger <Peter.Fruehber...@hte-company.de>
Subject RE: Possible incorrect unique.vm in mysql
Date Thu, 13 Mar 2008 14:26:39 GMT
I will do this, but momentarily the apache bugtracker site is a bit
laggy, needs endless time to load...

I` ll recheck tomorrow

Thx again
Peter

Am Donnerstag, den 13.03.2008, 15:01 +0100 schrieb Thomas Fischer:
> Ah ok, I overlooked that a name could be specified. But the dtd says
> 
> <!ELEMENT index (option*,index-column+)>
> <!ATTLIST index
>   name CDATA #IMPLIED
> >
> 
> and in this case you are right, the name should be used.  Would you mind to
> create a jira issue ?
> 
>    Thanks,
> 
>      Thomas
> 
> 
> Peter Frühberger <Peter.Fruehberger@hte-company.de> schrieb am 13.03.2008
> 14:47:39:
> 
> > Thx for your reply,
> >
> > Yes it is totally correct for mysql to create unique index without
> > special naming. mysql just uses the Name auf die Index-column as the
> > unique index name.
> >
> > But, if you do want to specify your own index naming, it is not
> > possible. The name attribut from <unique name="..."> is ignored totally.
> >
> >
> > In my opinion, torque should treat this like the following:
> >
> > if ("unique name" is specified) {
> >  unique $uniq.name ('column')
> > }
> > else {
> > unique ('column')
> > }
> >
> > Thx
> > Peter
> >
> > Am Donnerstag, den 13.03.2008, 14:36 +0100 schrieb Thomas Fischer:
> > > As far as I know, you CAN define and index name, but you need not. For
> > > example, I have thested the following works with mysql 5.0
> > >
> > > CREATE TABLE `test` (`test` VARCHAR( 10 ) NOT NULL , UNIQUE (test))
> > >
> > > So in my eyes, the SQL generated by Torque is perfectly valid. Or did I
> > > miss something ?
> > >
> > >            Thomas
> > >
> > > Peter Frühberger <Peter.Fruehberger@hte-company.de> schrieb am
> 13.03.2008
> > > 11:46:08:
> > >
> > > > I am using version 3.3-RC3 of the torque maven plugin.
> > > >
> > > >
> > > > The following snippet of code:
> > > > <unique name="NAME_IDX">
> > > > <unique-column name="NAME"/>
> > > > </unique>
> > > >
> > > > generates the following mysql code:
> > > >
> > > > Create ...
> > > >    ...
> > > >     UNIQUE (NAME)
> > > > );
> > > >
> > > > The unique index name (NAME_IDX) is missing, it should correctly be:
> > > >
> > > > Create ...
> > > >    UNIQUE NAME_IDX (NAME);
> > > > );
> > > >
> > > >
> > > > changing the unique.vm in sql/base/mysql/unique.vm from
> > > > #foreach ($unique in $table.Unices)
> > > > UNIQUE($unique.ColumnList),
> > > > #end
> > > >
> > > > to
> > > > #foreach ($unique in $table.Unices)
> > > > UNIQUE $unique.Name ($unique.ColumnList),
> > > > #end
> > > >
> > > >
> > > > fixes this problem for me.
> > > >
> > > > Thx
> > > > Peter Frühberger
> > > > (sorry for sending through an exchange server ;-))
> > > >
> > > >
> > > >
> > > >
> > > > ---------------------------------------------------------------------
> > > > To unsubscribe, e-mail: torque-user-unsubscribe@db.apache.org
> > > > For additional commands, e-mail: torque-user-help@db.apache.org
> > > >
> > >
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: torque-user-unsubscribe@db.apache.org
> > > For additional commands, e-mail: torque-user-help@db.apache.org
> > >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: torque-user-unsubscribe@db.apache.org
> > For additional commands, e-mail: torque-user-help@db.apache.org
> >
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: torque-user-unsubscribe@db.apache.org
> For additional commands, e-mail: torque-user-help@db.apache.org
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: torque-user-unsubscribe@db.apache.org
For additional commands, e-mail: torque-user-help@db.apache.org


Mime
View raw message