db-torque-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Petr Bodnar (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (TORQUE-108) Criteria addJoin causes incorrect SQL to be generated when optional schema references are in use (Oracle)
Date Sat, 24 Oct 2015 08:33:27 GMT

    [ https://issues.apache.org/jira/browse/TORQUE-108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14972487#comment-14972487

Petr Bodnar commented on TORQUE-108:

Hi, when looking at the tests again, I think that the existing {{testInnerJoinImplicitWithAliasAndDefaultSchema}}
is already sufficient - the only real difference is that I tested with *outer* join which
is not that important difference from the Torque's architecture perspective, I guess.

Ad {{ColumnImpl}} - I can see why this was introduced, but I still don't think, from the perspective
of an API user, it was really necessary to remove the possibility of putting just String (and
*internally* calling {{new ColumnImpl(sqlExpression)}}) where it logically means just a column
name in most of the cases (compare with e. g. Hibernate's criteria API simplicity...).

> Criteria addJoin causes incorrect SQL to be generated when optional schema references
are in use (Oracle)
> ---------------------------------------------------------------------------------------------------------
>                 Key: TORQUE-108
>                 URL: https://issues.apache.org/jira/browse/TORQUE-108
>             Project: Torque
>          Issue Type: Bug
>          Components: Runtime
>    Affects Versions: 3.3-RC1, 3.3-RC2, 3.3-RC3
>         Environment: Linux, Java 1.6
>            Reporter: Brendan Miller
>            Assignee: Thomas Fox
>             Fix For: 4.0-beta1
>         Attachments: JoinBuilderTest.java, joinbuilder.patch
> I previously wrote about this to torque-user in Oct 2007.
> In a schema definition that includes torque.dsfactory.programs.schema, writing the following
> Criteria crit = new Criteria();
> crit.addJoin(TransactionPeer.ORDER_ID, OrderPeer.ID);
> crit.add(TransactionPeer.ACCT_ID, account.getID());
> List<Order> orders = OrderPeer.doSelect(crit);
> generates
> Upon examining the Torque code, it appears that SQLBuilder.processJoins does not add
the full table names, while SQLBuilder.processCriterions does.
> Shouldn't they both add the full table names?

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: torque-dev-unsubscribe@db.apache.org
For additional commands, e-mail: torque-dev-help@db.apache.org

View raw message