db-torque-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Thomas Vandahl ...@apache.org>
Subject Re: proposed API Change: make PreparedStatementPart an interface
Date Sun, 20 Sep 2015 19:03:58 GMT
On 19.09.15 03:09, Thomas Fox wrote:
> Hi,
> in order to solve 
> https://issues.apache.org/jira/browse/TORQUE-290
> I'd like to make org.apache.torque.criteria.PreparedStatementPart an interface
> with the current PreparedStatementPart being renamed to PreparedStatementPartImpl
> and an implementation of that interface.
> As the class is in the package org.apache.torque.criteria,
> this is a change in the public API of Torque.
> My personal guess is that this change  will not affect many people as
> the only reason this class was moved to the above package was because 
> it is used in the implementation of the method Criteria.addJoin().
> Does anybody object to that change ?

Well, that depends on our policy regarding versioning. Within Commons
for example this would require a new major version if it is not binary
compatible. Personally, I don't see a big problem with this change if it
is documented properly.

Bye, Thomas

To unsubscribe, e-mail: torque-dev-unsubscribe@db.apache.org
For additional commands, e-mail: torque-dev-help@db.apache.org

View raw message