db-torque-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tfisc...@apache.org
Subject svn commit: r1483228 - in /db/torque/torque4/trunk/torque-templates/src/main: java/org/apache/torque/templates/transformer/sql/SQLModelTransformer.java plugin-config/findbugs-exclude.xml
Date Thu, 16 May 2013 08:05:02 GMT
Author: tfischer
Date: Thu May 16 08:05:01 2013
New Revision: 1483228

URL: http://svn.apache.org/r1483228
Log:
TORQUE-273
fix boolean compare problem found by findbugs
exclude false positives from findbugs analysis

Modified:
    db/torque/torque4/trunk/torque-templates/src/main/java/org/apache/torque/templates/transformer/sql/SQLModelTransformer.java
    db/torque/torque4/trunk/torque-templates/src/main/plugin-config/findbugs-exclude.xml

Modified: db/torque/torque4/trunk/torque-templates/src/main/java/org/apache/torque/templates/transformer/sql/SQLModelTransformer.java
URL: http://svn.apache.org/viewvc/db/torque/torque4/trunk/torque-templates/src/main/java/org/apache/torque/templates/transformer/sql/SQLModelTransformer.java?rev=1483228&r1=1483227&r2=1483228&view=diff
==============================================================================
--- db/torque/torque4/trunk/torque-templates/src/main/java/org/apache/torque/templates/transformer/sql/SQLModelTransformer.java
(original)
+++ db/torque/torque4/trunk/torque-templates/src/main/java/org/apache/torque/templates/transformer/sql/SQLModelTransformer.java
Thu May 16 08:05:01 2013
@@ -307,7 +307,7 @@ public class SQLModelTransformer impleme
         // primary keys
         for (final Column column : table.columnList)
         {
-            if (Boolean.TRUE == column.primaryKey)
+            if (Boolean.TRUE.equals(column.primaryKey))
             {
                 table.primaryKeyList.add(column);
             }

Modified: db/torque/torque4/trunk/torque-templates/src/main/plugin-config/findbugs-exclude.xml
URL: http://svn.apache.org/viewvc/db/torque/torque4/trunk/torque-templates/src/main/plugin-config/findbugs-exclude.xml?rev=1483228&r1=1483227&r2=1483228&view=diff
==============================================================================
--- db/torque/torque4/trunk/torque-templates/src/main/plugin-config/findbugs-exclude.xml (original)
+++ db/torque/torque4/trunk/torque-templates/src/main/plugin-config/findbugs-exclude.xml Thu
May 16 08:05:01 2013
@@ -24,6 +24,22 @@
         Do not complain about unused public fields in the model.
     -->
     <Package name="org.apache.torque.templates.model" />
-    <Bug pattern="URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD,UUF_UNUSED_PUBLIC_OR_PROTECTED_FIELD"
/>
+    <Bug pattern="URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD,UUF_UNUSED_PUBLIC_OR_PROTECTED_FIELD,UWF_UNWRITTEN_PUBLIC_OR_PROTECTED_FIELD"
/>
+  </Match>
+  <Match>
+    <!-- 
+        Do not complain about unwritten public fields
+        (the objects in question are passed in anyway).
+    -->
+    <Class name="org.apache.torque.templates.transformer.SchemaTypeHelper" />
+    <Bug pattern="NP_UNWRITTEN_PUBLIC_OR_PROTECTED_FIELD" />
+  </Match>
+  <Match>
+    <!-- 
+        Do not complain about unwritten public fields
+        (the objects in question are passed in anyway).
+    -->
+    <Class name="org.apache.torque.templates.transformer.sql.SQLModelTransformer" />
+    <Bug pattern="NP_UNWRITTEN_PUBLIC_OR_PROTECTED_FIELD" />
   </Match>
 </FindBugsFilter>
\ No newline at end of file



---------------------------------------------------------------------
To unsubscribe, e-mail: torque-dev-unsubscribe@db.apache.org
For additional commands, e-mail: torque-dev-help@db.apache.org


Mime
View raw message