Mailing-List: contact torque-dev-help@db.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Apache Torque Developers List" <torque-dev@db.apache.org>
Date: Mon, 24 Sep 2012 18:08:18 +1100 (NCT)
From: "Thomas Fox (JIRA)" <jira@apache.org>
To: torque-dev@db.apache.org
Message-ID: <1096375922.115505.1348470498799.JavaMail.jiratomcat@arcas>
In-Reply-To: 
 <21071819.9353.1335272734801.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Closed] (TORQUE-195) Remove autocommit handling from
 Transaction management
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/TORQUE-195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Thomas Fox closed TORQUE-195.
-----------------------------

    
> Remove autocommit handling from Transaction management
> ------------------------------------------------------
>
>                 Key: TORQUE-195
>                 URL: https://issues.apache.org/jira/browse/TORQUE-195
>             Project: Torque
>          Issue Type: Improvement
>          Components: Runtime
>    Affects Versions: 3.3, 3.3.1
>            Reporter: Thomas Fox
>            Assignee: Thomas Fox
>             Fix For: 4.0-beta1
>
>
> Currently, transaction handling is very unclean.
> - Transaction.beginOptional sets autocommit to false on a connection under certain conditions, but Transaction.commit() does not know what autocommit was beforehand and sets it to true under certain conditions, regardless of the connection state before
> - The field Criteria.useTransaction can be used to disable the autocommit switching when starting a transaction (but not the switching back)
> Autocommit should be handled by the connection pool, not by the OR Mapper, and should be removed from the Torque code. This would lead to the following modifications
> - remove the Transaction.beginOptional method
> - remove the useTransaction field from Criteria
> If an explicit transaction handling is desired, this can still be done by doing the connection/transaction handling in application code and using the methods which take a transaction.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: torque-dev-unsubscribe@db.apache.org
For additional commands, e-mail: torque-dev-help@db.apache.org