Mailing-List: contact torque-dev-help@db.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Apache Torque Developers List" <torque-dev@db.apache.org>
Date: Tue, 24 Apr 2012 13:05:34 +0000 (UTC)
From: "Thomas Fox (JIRA)" <jira@apache.org>
To: torque-dev@db.apache.org
Message-ID: <21071819.9353.1335272734801.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Created] (TORQUE-195) Remove autocommit handling from
 Transaction management
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

Thomas Fox created TORQUE-195:
---------------------------------

             Summary: Remove autocommit handling from Transaction management
                 Key: TORQUE-195
                 URL: https://issues.apache.org/jira/browse/TORQUE-195
             Project: Torque
          Issue Type: Improvement
          Components: Runtime
    Affects Versions: 3.3.1, 3.3
            Reporter: Thomas Fox


Currently, transaction handling is very unclean.
- Transaction.beginOptional sets autocommit to false on a connection under certain conditions, but Transaction.commit() does not know what autocommit was beforehand and sets it to true under certain conditions, regardless of the connection state before
- The field Criteria.useTransaction can be used to disable the autocommit switching when starting a transaction (but not the switching back)

Autocommit should be handled by the connection pool, not by the OR Mapper, and should be removed from the Torque code. This would lead to the following modifications
- remove the Transaction.beginOptional method
- remove the useTransaction field from Criteria
If an explicit transaction handling is desired, this can still be done by doing the connection/transaction handling in application code and using the methods which take a transaction.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        
---------------------------------------------------------------------
To unsubscribe, e-mail: torque-dev-unsubscribe@db.apache.org
For additional commands, e-mail: torque-dev-help@db.apache.org