Return-Path: X-Original-To: apmail-db-torque-dev-archive@www.apache.org Delivered-To: apmail-db-torque-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 842DB99EC for ; Sat, 11 Feb 2012 05:01:37 +0000 (UTC) Received: (qmail 64221 invoked by uid 500); 11 Feb 2012 05:01:36 -0000 Delivered-To: apmail-db-torque-dev-archive@db.apache.org Received: (qmail 64128 invoked by uid 500); 11 Feb 2012 05:01:25 -0000 Mailing-List: contact torque-dev-help@db.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Help: List-Post: List-Id: "Apache Torque Developers List" Reply-To: "Apache Torque Developers List" Delivered-To: mailing list torque-dev@db.apache.org Received: (qmail 64120 invoked by uid 99); 11 Feb 2012 05:01:19 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 11 Feb 2012 05:01:19 +0000 X-ASF-Spam-Status: No, hits=-0.0 required=5.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: local policy) Received: from [217.24.207.26] (HELO mail.seitenbau.net) (217.24.207.26) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 11 Feb 2012 05:01:12 +0000 Received: from www.seitenbau.net ([192.168.15.18]:31044) by mail.seitenbau.net with esmtp (Exim 4.69) (envelope-from ) id 1Rw54j-0002FU-1K for torque-dev@db.apache.org; Sat, 11 Feb 2012 06:00:41 +0100 X-CTCH-RefID: str=0001.0A0B0201.4F35F5F9.006E,ss=1,fgs=0 In-Reply-To: <55B8568AFA5F144F886F18186BAD5B2C2BEE342C37@durham-e2k7mb1.dukece.com> References: <4F2E935F.7090307@apache.org> <55B8568AFA5F144F886F18186BAD5B2C2BEE342C37@durham-e2k7mb1.dukece.com> Subject: RE: location of save() methods X-KeepSent: 521674E9:EB552573-C12579A1:001A384E; type=4; name=$KeepSent To: "Apache Torque Developers List" X-Mailer: Lotus Notes Release 8.5.1 September 28, 2009 Message-ID: From: Thomas Fox Date: Sat, 11 Feb 2012 06:00:40 +0100 X-MIMETrack: Serialize by Router on www/seitenbau(Release 8.5HF467 | May 15, 2009) at 02/11/2012 06:00:41 MIME-Version: 1.0 Content-type: text/plain; charset=US-ASCII ok, so it seems that you are not convinced of relocating the save methods, and so the default location of the save methods should stay as they are. I'd then go for the following: - modify the template for the save methods such that it can be used in the peer classes as well as in the dbobject classes (from looking at it this should not bee too difficult) - add a generation option for the location of the save methods, defaulting to the dbobject methods. ok ? If the location of the save methods is the peer classes, public isSaving() and setSaving() methods are needed. Is it ok to add them even if the save methods are in the dbObject methods (in the spirit of TORQUE-116 ) Thomas --------------------------------------------------------------------- To unsubscribe, e-mail: torque-dev-unsubscribe@db.apache.org For additional commands, e-mail: torque-dev-help@db.apache.org