Mailing-List: contact torque-dev-help@db.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Apache Torque Developers List" <torque-dev@db.apache.org>
Received-SPF: pass (athena.apache.org: local policy)
Subject: location of save() methods
To: Apache Torque Developers List <torque-dev@db.apache.org>
Message-ID: 
 <OF4878F70D.F0940D36-ONC125799B.0045765A-4125799B.0046C162@seitenbau.net>
From: Thomas Fox <Thomas.Fox@seitenbau.net>
Date: Sun, 5 Feb 2012 13:52:48 +0100
MIME-Version: 1.0
Content-type: text/plain; charset=US-ASCII


I'd like to turn your attention to
https://issues.apache.org/jira/browse/TORQUE-180
which is about whether the save() methods should be in the generated
dbObject classes or in the peer classes or both.
My personal opinion is that it would be more consistent if the save methods
were in the peer classes because almost all database-related operations are
already there and it would be possible to use the dbObject objects as pure
transport objects without database functionality.

Are there any objections against implementing this ticket? The idea would
be to move the functionality of the save methods to the peer classes and
have delegate methods in the dbObject classes (the generation of these
methods can be turned on and off by setting an option). Like

AuthorPeer:

   public void save(Author toSave) throws TorqueException
   {
       ... (database logic)
   }

Author (optional):

  public void save() throws TorqueException
  {
    AuthorPeer.save(this);
  }

If there are no objections, what is your preference for the default
behaviour ?
Shold the save methods be in the peer classes only by default or in the
peer and dbObject classes ?
what should the method name in the peer classes be ? save() or doSave() ?

      Thomas


---------------------------------------------------------------------
To unsubscribe, e-mail: torque-dev-unsubscribe@db.apache.org
For additional commands, e-mail: torque-dev-help@db.apache.org