Return-Path: X-Original-To: apmail-db-torque-dev-archive@www.apache.org Delivered-To: apmail-db-torque-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7F70C777E for ; Sun, 11 Dec 2011 19:08:53 +0000 (UTC) Received: (qmail 80865 invoked by uid 500); 11 Dec 2011 19:08:53 -0000 Delivered-To: apmail-db-torque-dev-archive@db.apache.org Received: (qmail 80840 invoked by uid 500); 11 Dec 2011 19:08:53 -0000 Mailing-List: contact torque-dev-help@db.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Help: List-Post: List-Id: "Apache Torque Developers List" Reply-To: "Apache Torque Developers List" Delivered-To: mailing list torque-dev@db.apache.org Received: (qmail 80832 invoked by uid 500); 11 Dec 2011 19:08:53 -0000 Received: (qmail 80828 invoked by uid 99); 11 Dec 2011 19:08:53 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 11 Dec 2011 19:08:53 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 11 Dec 2011 19:08:50 +0000 Received: from eris.apache.org (localhost [127.0.0.1]) by eris.apache.org (Postfix) with ESMTP id CE774238889B; Sun, 11 Dec 2011 19:08:28 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1213042 - /db/torque/torque4/trunk/torque-runtime/src/main/java/org/apache/torque/util/functions/FunctionFactory.java Date: Sun, 11 Dec 2011 19:08:28 -0000 To: torque-commits@db.apache.org From: tfischer@apache.org X-Mailer: svnmailer-1.0.8-patched Message-Id: <20111211190828.CE774238889B@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: tfischer Date: Sun Dec 11 19:08:28 2011 New Revision: 1213042 URL: http://svn.apache.org/viewvc?rev=1213042&view=rev Log: Fix some PMD bugs Modified: db/torque/torque4/trunk/torque-runtime/src/main/java/org/apache/torque/util/functions/FunctionFactory.java Modified: db/torque/torque4/trunk/torque-runtime/src/main/java/org/apache/torque/util/functions/FunctionFactory.java URL: http://svn.apache.org/viewvc/db/torque/torque4/trunk/torque-runtime/src/main/java/org/apache/torque/util/functions/FunctionFactory.java?rev=1213042&r1=1213041&r2=1213042&view=diff ============================================================================== --- db/torque/torque4/trunk/torque-runtime/src/main/java/org/apache/torque/util/functions/FunctionFactory.java (original) +++ db/torque/torque4/trunk/torque-runtime/src/main/java/org/apache/torque/util/functions/FunctionFactory.java Sun Dec 11 19:08:28 2011 @@ -65,8 +65,10 @@ public final class FunctionFactory boolean distinct) throws Exception { - return functionInstance(dbName, FunctionEnum.AVG, - new Object[]{column, new Boolean(distinct)}); + return functionInstance( + dbName, + FunctionEnum.AVG, + new Object[]{column, Boolean.valueOf(distinct)}); } /** * Convenience method for creating a non-distinct function that uses @@ -98,8 +100,10 @@ public final class FunctionFactory boolean distinct) throws Exception { - return functionInstance(dbName, FunctionEnum.COUNT, - new Object[]{column, new Boolean(distinct)}); + return functionInstance( + dbName, + FunctionEnum.COUNT, + new Object[]{column, Boolean.valueOf(distinct)}); } /** * Convenience method for creating a non-distinct function that uses @@ -131,8 +135,10 @@ public final class FunctionFactory boolean distinct) throws Exception { - return functionInstance(dbName, FunctionEnum.MAX, - new Object[]{column, new Boolean(distinct)}); + return functionInstance( + dbName, + FunctionEnum.MAX, + new Object[]{column, Boolean.valueOf(distinct)}); } /** * Convenience method for creating a non-distinct function that uses @@ -164,8 +170,10 @@ public final class FunctionFactory boolean distinct) throws Exception { - return functionInstance(dbName, FunctionEnum.MIN, - new Object[]{column, new Boolean(distinct)}); + return functionInstance( + dbName, + FunctionEnum.MIN, + new Object[]{column, Boolean.valueOf(distinct)}); } /** * Convenience method for creating a non-distinct function that uses @@ -197,8 +205,10 @@ public final class FunctionFactory boolean distinct) throws Exception { - return functionInstance(dbName, FunctionEnum.SUM, - new Object[]{column, new Boolean(distinct)}); + return functionInstance( + dbName, + FunctionEnum.SUM, + new Object[]{column, Boolean.valueOf(distinct)}); } /** * Convenience method for creating a non-distinct function that uses --------------------------------------------------------------------- To unsubscribe, e-mail: torque-dev-unsubscribe@db.apache.org For additional commands, e-mail: torque-dev-help@db.apache.org