Return-Path: X-Original-To: apmail-db-torque-dev-archive@www.apache.org Delivered-To: apmail-db-torque-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 56F517116 for ; Mon, 18 Jul 2011 14:18:23 +0000 (UTC) Received: (qmail 47375 invoked by uid 500); 18 Jul 2011 14:18:23 -0000 Delivered-To: apmail-db-torque-dev-archive@db.apache.org Received: (qmail 47326 invoked by uid 500); 18 Jul 2011 14:18:22 -0000 Mailing-List: contact torque-dev-help@db.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Help: List-Post: List-Id: "Apache Torque Developers List" Reply-To: "Apache Torque Developers List" Delivered-To: mailing list torque-dev@db.apache.org Received: (qmail 47315 invoked by uid 99); 18 Jul 2011 14:18:22 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 18 Jul 2011 14:18:22 +0000 X-ASF-Spam-Status: No, hits=-2001.1 required=5.0 tests=ALL_TRUSTED,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 18 Jul 2011 14:18:20 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 3FD4D41519 for ; Mon, 18 Jul 2011 14:17:59 +0000 (UTC) Date: Mon, 18 Jul 2011 14:17:59 +0000 (UTC) From: "Thomas Fox (JIRA)" To: torque-dev@db.apache.org Message-ID: <2091673474.252.1310998679257.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <1272682427.17810.1310745660111.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (TORQUE-166) remove the getOMClass() method, the CLASS_DEFAULT constant and the initClass() method in the generated peers MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/TORQUE-166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13067047#comment-13067047 ] Thomas Fox commented on TORQUE-166: ----------------------------------- What about generating a getOMInstance method in the Peer returning a new OMClass() ? In my opinion we should avoid using reflection wherever possible. Also, getOMInstance() is more flexible, one can override the method and instantiate classes which do not have a no-arg constructor. When needed, one can still find out the OMClass by getOMInstance().getClass() > remove the getOMClass() method, the CLASS_DEFAULT constant and the initClass() method in the generated peers > ------------------------------------------------------------------------------------------------------------ > > Key: TORQUE-166 > URL: https://issues.apache.org/jira/browse/TORQUE-166 > Project: Torque > Issue Type: Improvement > Reporter: Thomas Fox > Assignee: Thomas Fox > > These methods and constants were used by village and are not needed any more. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: torque-dev-unsubscribe@db.apache.org For additional commands, e-mail: torque-dev-help@db.apache.org