Mailing-List: contact torque-dev-help@db.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Apache Torque Developers List" <torque-dev@db.apache.org>
Received-SPF: pass (athena.apache.org: domain of greg.monroe@dukece.com
 designates 152.3.166.24 as permitted sender)
From: Greg Monroe <Greg.Monroe@dukece.com>
To: 'Apache Torque Developers List' <torque-dev@db.apache.org>
Date: Thu, 5 May 2011 11:16:40 -0400
Subject: RE: create package org.apache.torque.sql in torque runtime
Thread-Topic: create package org.apache.torque.sql in torque runtime
Thread-Index: AcwLKMT3jzYOFbs8RdatjspQPFXpWgADCgWQ
Message-ID: 
 <55B8568AFA5F144F886F18186BAD5B2C06EC3E9579@durham-e2k7mb1.dukece.com>
References: 
 <OF262F213A.7E2D550B-ONC1257887.0049C55D-C1257887.004A44F5@seitenbau.net>
In-Reply-To: 
 <OF262F213A.7E2D550B-ONC1257887.0049C55D-C1257887.004A44F5@seitenbau.net>
Accept-Language: en-US
Content-Language: en-US
acceptlanguage: en-US
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"

+1 on creating refactoring the util package=2E  I've often thought it =0D=
=0Awas overloaded/not named correctly for some classes=2E=0D=0A=0D=0AIf we =
are doing this, should we also consider moving BasePeer, =0D=0ACriteria, an=
d Transaction as well?  IMHO, These are not utility =0D=0Aclasses but part =
of the SQL Language modeling of Torque and =0D=0Ashould be in a package tha=
t states this=2E=0D=0A=0D=0AThis way we would have the om package for the d=
ata storage model=0D=0Aand the sql package for SQL actions model=2E=0D=0A=
=0D=0AThe util package becomes more clearly the place for classes that =0D=
=0Asupply additional utility above the core=2E=0D=0A=0D=0AOf course, this m=
ay be too much refactoring and require lots of=0D=0ATorque using code to be=
 rewritten=2E=2E=2E=2E hmm, maybe we could leave the=0D=0Acurrent main clas=
ses in util as subclasses of the new classes in =0D=0Athe sql package, mark=
ed as deprecated and due to be dropped=2E=2E=2E =0D=0A=0D=0A=0D=0A-----Orig=
inal Message-----=0D=0AFrom: Thomas Fox [mailto:Thomas=2EFox@seitenbau=2Ene=
t] =0D=0ASent: Thursday, May 05, 2011 9:31 AM=0D=0ATo: Apache Torque Develo=
pers List=0D=0ASubject: create package org=2Eapache=2Etorque=2Esql in torqu=
e runtime=0D=0A=0D=0A=0D=0AI'd like to create a new package org=2Eapache=2E=
torque=2Esql for all classes=0D=0Awhich main purpose is SQL generation and =
storage of SQL (but classes which=0D=0Acan be rendered into SQL like e=2Eg=
=2E Criteria would stay where they are)=2E=0D=0AThis would serve two purpos=
es:=0D=0A- The util package has become quite large and the sql generation c=
lasses=0D=0Aserve a different purpose than most of the other classes (which=
 are used=0D=0Adirectly by torque users)=0D=0A- The sql package could be de=
clared as torque-internal (i=2Ee=2E it is not=0D=0Aconsidered API and we ca=
n change the method signatures there)=0D=0A=0D=0AThe affected classes would=
 be Query, SQLBuilder, JoinBuilder and=0D=0ASqlExpression in org=2Eapache=
=2Etorque=2Eutil=2E=0D=0A=0D=0AFurthermore, I'd like to merge the SqlExpres=
sion code into SQLBuilder (I do=0D=0Anot see any criteria to divide the sql=
 generation code into these two=0D=0Aclasses) and restructure the SqlExpres=
sion code a bit (it is currently not=0D=0Avery readable)=2E=0D=0A=0D=0AAny =
objections ?=0D=0A=0D=0A      Thomas=0D=0A=0D=0A=0D=0A---------------------=
------------------------------------------------=0D=0ATo unsubscribe, e-mai=
l: torque-dev-unsubscribe@db=2Eapache=2Eorg=0D=0AFor additional commands, e=
-mail: torque-dev-help@db=2Eapache=2Eorg=0D=0A=0D=0ADukeCE Privacy Statemen=
t:=0D=0APlease be advised that this e-mail and any files transmitted with=
=0D=0Ait are confidential communication or may otherwise be privileged or=
=0D=0Aconfidential and are intended solely for the individual or entity=0D=
=0Ato whom they are addressed=2E If you are not the intended recipient=0D=
=0Ayou may not rely on the contents of this email or any attachments,=0D=0A=
and we ask that you please not read, copy or retransmit this=0D=0Acommunica=
tion, but reply to the sender and destroy the email, its=0D=0Acontents, and=
 all copies thereof immediately=2E Any unauthorized=0D=0Adissemination, dis=
tribution or copying of this communication is=0D=0Astrictly prohibited=2E

---------------------------------------------------------------------
To unsubscribe, e-mail: torque-dev-unsubscribe@db.apache.org
For additional commands, e-mail: torque-dev-help@db.apache.org