db-torque-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Thomas Vandahl ...@apache.org>
Subject Re: svn commit: r1038355 - /db/torque/village/trunk/src/java/com/workingdogs/village/Schema.java
Date Thu, 02 Dec 2010 21:27:11 GMT
On 28.11.10 21:42, Thomas Fox wrote:
>> Could you please re-run your test project against Oracle with this
>> version and tell me the findings?
> 
> Looks good. The test project runs ok against oracle using the current
> village 3.3.1 trunk.
> I did not run the test project for other databases.

Ok. I tested against MySQL and PostgreSQL and the test project worked
fine. Both consistently fail on SummaryHelperTest, however.

By looking at the code of SummaryHelper I guess this is based on the
fact that the results are put into a case-sensitive OrderedMap using the
column names returned from the database as a key. In the case of
Postgresql for example, the database returns the column names in lower
case, so that the test cannot find them. See example output of
dumpResults():

---8<---
"group_by1", "count_recs", "avg_int1", "min_int1", "max_int1",
"sum_int1", "avg_float1", "min_float1", "max_float1", "sum_float1", "upper"
"A1", 4, 2.5000000000000000, 1, 4, 10, 5.0, 2.0, 8.0, 20.0, "A1"
"B1", 4, 3.5000000000000000, 2, 5, 14, 7.0, 4.0, 10.0, 28.0, "B1"
"C1", 4, 4.5000000000000000, 3, 6, 18, 9.0, 6.0, 12.0, 36.0, "C1"
"D1", 4, 5.5000000000000000, 4, 7, 22, 11.0, 8.0, 14.0, 44.0, "D1"
---8<---

So I believe either the test or the implementation is wrong.

Other than this, shall we try another RC for Village 3.3.1?

Bye, Thomas

---------------------------------------------------------------------
To unsubscribe, e-mail: torque-dev-unsubscribe@db.apache.org
For additional commands, e-mail: torque-dev-help@db.apache.org


Mime
View raw message