Mailing-List: contact torque-dev-help@db.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Apache Torque Developers List" <torque-dev@db.apache.org>
Received-SPF: pass (nike.apache.org: local policy)
In-Reply-To: <1285841001.17277.200.camel@ws13-ubuntu.u-form.local>
References: 
 <OF3544DC2A.9BD2F6AA-ONC12577AB.006C7C40-C12577AB.006D2503@seitenbau.net>
	 <4CA388E8.80609@apache.org>
	 <1285834375.17277.191.camel@ws13-ubuntu.u-form.local>
	 <OF018D6E11.4E518FE8-ONC12577AE.00304313-C12577AE.00357648@seitenbau.net>
 <1285841001.17277.200.camel@ws13-ubuntu.u-form.local>
Subject: Re: Attibute modifications in schema
To: "Apache Torque Developers List" <torque-dev@db.apache.org>
Message-ID: 
 <OF531C09F4.6B8EC548-ONC12577AF.00332E67-C12577AF.004F18B6@seitenbau.net>
From: Thomas Fischer <fischer@seitenbau.net>
Date: Fri, 1 Oct 2010 16:23:54 +0200
MIME-Version: 1.0
Content-type: text/plain; charset=US-ASCII

> ...
> About the problem with inheritance I guess there needs to be some
> discussion. There would be one way which possibly most people around
> here do not like, that would be bytecode enhancement after compilation.
> Since this would be some kind of religious war I'm open to other
> possibilites.
>
> I would like to see some discussion on that topic.

My personal goal would be to remove te necessity to inherit from
BaseObject. If anything like it is required, the object should rather
implement an interface.

> > b) I would welcome an annotation-based approach. I do not think
> > implementation would be too difficult given the 4.0 generator
> > implementation, it would mean to implement just another
> > org.apache.torque.generator.source.SourceProvider (there are already
two of
> > them). Of course some design questions need to be splved, which might
be
> > difficult in detail, but the implementation to the generator is
> > straightforward.
>
> I would try to implement a SourceProvider in the first stage after there
> was some discussion, enough interest and a basic concept how to
> implement it.

Personally I'm not interested, I'd rather edit an XML file than annotate
classes. Others? You can also ask at the users list.

I have thought a bit about the AnnotationSourceProvider class. It could be
split in two parts:
- A general AnnotationSourceProvider which reads annotated classes (this
would be in the generator). It would have an annotation processor
configured in, which translates the annotations to a source tree.
The annotationProcessor interface would also live in the generator. It
would get e.g. a list of annotated classes which themselves contain the
annotated methods (and members, but personally I do not think annotating
members is a good idea) and would be responsible to create a source tree
from the annotated classes. General helpers (e.g. add all annotation
attributes as attributes of an elment in teh source tree) would also live
in the generator.
- The annotation processor and the specific annotations would be part of
the templates.

    Thomas


---------------------------------------------------------------------
To unsubscribe, e-mail: torque-dev-unsubscribe@db.apache.org
For additional commands, e-mail: torque-dev-help@db.apache.org