Mailing-List: contact torque-dev-help@db.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Apache Torque Developers List" <torque-dev@db.apache.org>
Received-SPF: neutral (athena.apache.org: local policy)
Message-ID: <4CCDD33A.4080500@apache.org>
Date: Sun, 31 Oct 2010 21:36:10 +0100
From: Thomas Vandahl <tv@apache.org>
User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US;
 rv:1.9.2.11) Gecko/20101013 Lightning/1.0b2 Thunderbird/3.1.5
MIME-Version: 1.0
To: Apache Torque Developers List <torque-dev@db.apache.org>
Subject: Re: created torque 4 branch with village removed
References: 
 <OF98697049.4339EDBD-ONC12577C9.00771014-C12577C9.007EE878@seitenbau.net>
 <OFE7E4F55C.4F16F807-ONC12577CB.006EA851-C12577CB.007025BF@seitenbau.net>
In-Reply-To: 
 <OFE7E4F55C.4F16F807-ONC12577CB.006EA851-C12577CB.007025BF@seitenbau.net>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit

Hi Thomas,

On 29.10.10 22:24, Thomas Fox wrote:
>> Of course there are a few things left to do (which I will hopefully
> tackle
>> in the next few weeks):

Great stuff you did. I thought this would need much more time. Respect.

>> - check whether to revive the doPsSelect methods or whether all selects
> can
>> use prepared statements
> 
> Re-added BasePeer.doPSSelect() for now.

This method has some weaknesses IIRC. It dos not work correctly with
selects containing joins. I'd prefer to use prepared statements for all
selects if at all possible and I don't think we need separate methods.

>> - there was come code in doDelete which handled cascading deletes (at
> leats
>> theoretically, never saw it working) tris needs to be reimplemented
> 
> Not re-added. The code can definitely not have worked for composite foreign
> keys because there is no way to tell a composite foreign key from the
> database map.

Still I'm pretty sure that deletes containing joins do not work
correctly. So there should be another solution some day.

>> - Maybe one can clean up LargeSelect from the reflection stuff therein
> 
> Not while the Peers have static methods.
>> ...

I beg to differ. LargeSelect just tries to call the methods
addSelectColumns() and populateObject() on the given builder class. You
can provide any class you want here. I'd prefer to use some kind of
Builder-interface for this, however.

Bye, Thomas.

---------------------------------------------------------------------
To unsubscribe, e-mail: torque-dev-unsubscribe@db.apache.org
For additional commands, e-mail: torque-dev-help@db.apache.org