Return-Path: Delivered-To: apmail-db-torque-dev-archive@www.apache.org Received: (qmail 45900 invoked from network); 21 Oct 2010 06:32:32 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 21 Oct 2010 06:32:32 -0000 Received: (qmail 22496 invoked by uid 500); 21 Oct 2010 06:32:32 -0000 Delivered-To: apmail-db-torque-dev-archive@db.apache.org Received: (qmail 22454 invoked by uid 500); 21 Oct 2010 06:32:31 -0000 Mailing-List: contact torque-dev-help@db.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Help: List-Post: List-Id: "Apache Torque Developers List" Reply-To: "Apache Torque Developers List" Delivered-To: mailing list torque-dev@db.apache.org Received: (qmail 22446 invoked by uid 99); 21 Oct 2010 06:32:30 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 21 Oct 2010 06:32:30 +0000 X-ASF-Spam-Status: No, hits=2.2 required=10.0 tests=HTML_MESSAGE,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: local policy) Received: from [81.92.1.9] (HELO smtp-a.tal.de) (81.92.1.9) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 21 Oct 2010 06:32:21 +0000 Received: from mail1.u-form.de (p5098b4be.dip0.t-ipconnect.de [80.152.180.190]) (Authenticated sender: relay@u-form.de) by smtp-a.tal.de (Postfix) with ESMTP id 622D21051FE7 for ; Thu, 21 Oct 2010 08:32:00 +0200 (CEST) Received: from sbs2003.u-form.local ([192.168.10.1]:19943 helo=u-form.local) by mail1.u-form.de with esmtp (Exim 4.69) (envelope-from ) id 1P8ogq-0005cP-0Y for torque-dev@db.apache.org; Thu, 21 Oct 2010 08:31:52 +0200 Received: from [192.168.16.100] ([192.168.16.100]) by u-form.local with Microsoft SMTPSVC(6.0.3790.4675); Thu, 21 Oct 2010 08:31:54 +0200 Subject: Re: svn commit: r1024374 - /db/torque/torque4/trunk/torque-generator/src/main/java/org/apache/torque/generator/source/SourceElement.java From: Christoph Engelbert To: Apache Torque Developers List In-Reply-To: <20101019194118.D35BE23888E4@eris.apache.org> References: <20101019194118.D35BE23888E4@eris.apache.org> Content-Type: multipart/alternative; boundary="=-Yxr5BlBpOYlBYcRw4xVo" Date: Thu, 21 Oct 2010 08:31:51 +0200 Message-ID: <1287642711.2698.1.camel@ws13-ubuntu.u-form.local> Mime-Version: 1.0 X-Mailer: Evolution 2.28.3 X-OriginalArrivalTime: 21 Oct 2010 06:31:54.0125 (UTC) FILETIME=[A6F97BD0:01CB70E9] X-Virus-Checked: Checked by ClamAV on apache.org --=-Yxr5BlBpOYlBYcRw4xVo Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Hi Thomas, would a "return null" not work in this case? So you can prevent a lookup on the null reference or do you think that null could be a possible key? Am Dienstag, den 19.10.2010, 19:41 +0000 schrieb tfischer@apache.org: > Author: tfischer > Date: Tue Oct 19 19:41:18 2010 > New Revision: 1024374 > > URL: http://svn.apache.org/viewvc?rev=1024374&view=rev > Log: > fix bug in getTextAttribute() > > Modified: > db/torque/torque4/trunk/torque-generator/src/main/java/org/apache/torque/generator/source/SourceElement.java > > Modified: db/torque/torque4/trunk/torque-generator/src/main/java/org/apache/torque/generator/source/SourceElement.java > URL: http://svn.apache.org/viewvc/db/torque/torque4/trunk/torque-generator/src/main/java/org/apache/torque/generator/source/SourceElement.java?rev=1024374&r1=1024373&r2=1024374&view=diff > ============================================================================== > --- db/torque/torque4/trunk/torque-generator/src/main/java/org/apache/torque/generator/source/SourceElement.java (original) > +++ db/torque/torque4/trunk/torque-generator/src/main/java/org/apache/torque/generator/source/SourceElement.java Tue Oct 19 19:41:18 2010 > @@ -320,7 +320,7 @@ public class SourceElement > */ > public Object getTextAttribute() > { > - return attributes.get(name); > + return attributes.get(null); > } > > /** > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: torque-dev-unsubscribe@db.apache.org > For additional commands, e-mail: torque-dev-help@db.apache.org > --=-Yxr5BlBpOYlBYcRw4xVo--