db-torque-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "CG Monroe (JIRA)" <j...@apache.org>
Subject [jira] Commented: (TORQUE-148) remove throws clause in setter for referenced object by a foreign key
Date Mon, 04 Oct 2010 13:44:34 GMT

    [ https://issues.apache.org/jira/browse/TORQUE-148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12917603#action_12917603
] 

CG Monroe commented on TORQUE-148:
----------------------------------

As has been said in the dev list, exception handling is a beast.   I think a good solution
would be to replace this with  TorqueRuntimeException.  

The reason being is that this make re-writing code that currently has to handle TorqueExceptions
easier.  Just change the exception type.  Plus it simplifies future code by removing the exception
handing requirement because Runtime Exceptions don't get flagged by compiler.

> remove throws clause in setter for referenced object by a foreign key
> ---------------------------------------------------------------------
>
>                 Key: TORQUE-148
>                 URL: https://issues.apache.org/jira/browse/TORQUE-148
>             Project: Torque
>          Issue Type: Improvement
>            Reporter: Thomas Fischer
>            Assignee: Thomas Fischer
>            Priority: Minor
>             Fix For: 4.0
>
>
> for the schema
>   <table name="book" description="Book table">
>     ....
>     <foreign-key foreignTable="author">
>       <reference local="author_id" foreign="author_id"/>
>     </foreign-key>
>   </table>
> Torque generates (complexObjectModel=true) in BaseBook:
>     public void setAuthor(Author v) throws TorqueException
>     {
>         if (v == null)
>         {
>             setAuthorId(0);
>         }
>         else
>         {
>             setAuthorId(v.getAuthorId());
>         }
>         aAuthor = v;
>     }
> the TorqueException in the throws clause of the method is never thrown and should be
removed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: torque-dev-unsubscribe@db.apache.org
For additional commands, e-mail: torque-dev-help@db.apache.org


Mime
View raw message