db-torque-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas Fischer (JIRA)" <j...@apache.org>
Subject [jira] Commented: (TORQUE-148) remove throws clause in setter for referenced object by a foreign key
Date Tue, 05 Oct 2010 06:55:42 GMT

    [ https://issues.apache.org/jira/browse/TORQUE-148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12917889#action_12917889
] 

Thomas Fischer commented on TORQUE-148:
---------------------------------------

In this special case no runtime Exception is needed. It will never be thrown.

If we want to change the Torque exception handling in a global manner we should first discuss
on the dev list and then open another jira issue. Personally I like checked exceptions as
long as the exception hierarchy makes sense. But IMO this is a matter of taste.

> remove throws clause in setter for referenced object by a foreign key
> ---------------------------------------------------------------------
>
>                 Key: TORQUE-148
>                 URL: https://issues.apache.org/jira/browse/TORQUE-148
>             Project: Torque
>          Issue Type: Improvement
>            Reporter: Thomas Fischer
>            Assignee: Thomas Fischer
>            Priority: Minor
>             Fix For: 4.0
>
>
> for the schema
>   <table name="book" description="Book table">
>     ....
>     <foreign-key foreignTable="author">
>       <reference local="author_id" foreign="author_id"/>
>     </foreign-key>
>   </table>
> Torque generates (complexObjectModel=true) in BaseBook:
>     public void setAuthor(Author v) throws TorqueException
>     {
>         if (v == null)
>         {
>             setAuthorId(0);
>         }
>         else
>         {
>             setAuthorId(v.getAuthorId());
>         }
>         aAuthor = v;
>     }
> the TorqueException in the throws clause of the method is never thrown and should be
removed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: torque-dev-unsubscribe@db.apache.org
For additional commands, e-mail: torque-dev-help@db.apache.org


Mime
View raw message