Mailing-List: contact torque-dev-help@db.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Apache Torque Developers List" <torque-dev@db.apache.org>
Message-ID: <156848.260401281468796946.JavaMail.jira@thor>
Date: Tue, 10 Aug 2010 15:33:16 -0400 (EDT)
From: "Thomas Fischer (JIRA)" <jira@apache.org>
To: torque-dev@db.apache.org
Subject: [jira] Commented: (TORQUE-123) Statement  is left open when
 Exception is thrown in the QueryDataSet constructor  (ORA-01000)
In-Reply-To: <1927138765.1256030759371.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


    [ https://issues.apache.org/jira/browse/TORQUE-123?page=3Dcom.atlassian=
.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1289=
7014#action_12897014 ]=20

Thomas Fischer commented on TORQUE-123:
---------------------------------------

I'm going to use another patch:
        boolean ok =3D false;
        try
        {
            stmt =3D conn.createStatement();
            resultSet =3D stmt.executeQuery(selectStmt);
            schema =3D new Schema();
            schema.populate(resultSet.getMetaData(), null);
            ok =3D true;
        }=20
        finally
        {
            if (!ok)
            {
                try
                {
                    close();
                }
                catch (Exception ignored)
                {
                    // ignore as another exception is already thrown
                }
            }
        }

If anyone disagrees please state why

> Statement  is left open when Exception is thrown in the QueryDataSet cons=
tructor  (ORA-01000)
> -------------------------------------------------------------------------=
--------------------
>
>                 Key: TORQUE-123
>                 URL: https://issues.apache.org/jira/browse/TORQUE-123
>             Project: Torque
>          Issue Type: Bug
>          Components: Village
>    Affects Versions: 3.3
>         Environment: OS  =EF=BC=9ARedHat Enterprise Linux ES 4 update 4
> Java  =EF=BC=9A1.4.2_08
> Tomcat=EF=BC=9A4.1.31
> Torque=EF=BC=9A3.0.2
> JDBC(Oracle): ojdbc.jar(10.2.0.4)
>            Reporter: Kazu Nambo
>            Assignee: Thomas Fischer
>             Fix For: 3.3.1
>
>
> When syntax error(SQLException) happens at executeQuery in the constructo=
r QueryDataSet(Connection conn, String selectStmt), the member stmt is left=
 open and this problem sometimes results in ORA-01000 (Maximum open cursors=
 exceeded).
> In the upper layer like BasePeer#executeQuery method, it tries to close Q=
ueryDataSet instance by VillageUtils.close but it fails because the instanc=
e is null.
> Other exceptions may result in the same situation.
> If I try to make the constructor more robust as follows, it will work. (N=
o ORA-01000)
>     public QueryDataSet(Connection conn, String selectStmt)
>             throws SQLException, DataSetException
>     {
>         this.conn =3D conn;
>         selectString =3D new StringBuffer(selectStmt);
>         try=20
>         {
>         =09stmt =3D conn.createStatement();
>         =09resultSet =3D stmt.executeQuery(selectStmt);
>         =09schema =3D new Schema();
>         =09schema.populate(resultSet.getMetaData(), null);
>         }
>         catch (Exception e)
>         {
>         =09try {
>         =09=09if (null !=3D resultSet) {
>         =09=09=09resultSet.close();
>         =09=09}
>         =09} catch (Exception ignored) {}
>         =09try {
>         =09=09if (null !=3D stmt) {
>         =09=09=09stmt.close();
>         =09=09}
>         =09} catch (Exception ignored) {}
>         =09if (e instanceof SQLException)
>         =09=09throw (SQLException)e;
>         =09else if (e instanceof DataSetException)
>         =09=09throw (DataSetException)e;
>         =09else
>         =09=09throw new SQLException("QueryDataSet: exception caught.", e=
);
>         }
>     }

--=20
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: torque-dev-unsubscribe@db.apache.org
For additional commands, e-mail: torque-dev-help@db.apache.org