Return-Path: Delivered-To: apmail-db-torque-dev-archive@www.apache.org Received: (qmail 46640 invoked from network); 6 May 2007 10:57:27 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 6 May 2007 10:57:27 -0000 Received: (qmail 32484 invoked by uid 500); 6 May 2007 10:57:33 -0000 Delivered-To: apmail-db-torque-dev-archive@db.apache.org Received: (qmail 32468 invoked by uid 500); 6 May 2007 10:57:33 -0000 Mailing-List: contact torque-dev-help@db.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Help: List-Post: List-Id: "Apache Torque Developers List" Reply-To: "Apache Torque Developers List" Delivered-To: mailing list torque-dev@db.apache.org Received: (qmail 32457 invoked by uid 99); 6 May 2007 10:57:33 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 06 May 2007 03:57:33 -0700 X-ASF-Spam-Status: No, hits=-100.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.9] (HELO minotaur.apache.org) (140.211.11.9) by apache.org (qpsmtpd/0.29) with SMTP; Sun, 06 May 2007 03:57:26 -0700 Received: (qmail 46497 invoked by uid 1977); 6 May 2007 10:57:06 -0000 Received: from localhost (sendmail-bs@127.0.0.1) by localhost with SMTP; 6 May 2007 10:57:06 -0000 Date: Sun, 6 May 2007 03:57:06 -0700 (PDT) From: Thomas Fischer To: Apache Torque Developers List Subject: Re: svn commit: r535591 - in /db/torque: runtime/trunk/src/java/org/apache/torque/util/Criteria.java runtime/trunk/src/test/org/apache/torque/util/CriteriaTest.java site/trunk/xdocs/changes.xml In-Reply-To: <463DAD51.8090909@apache.org> Message-ID: <20070506035310.J20572@minotaur.apache.org> References: <20070506100508.272171A9838@eris.apache.org> <463DAD51.8090909@apache.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed X-Virus-Checked: Checked by ClamAV on apache.org The transient was added by Scott when he tried to serialize the Criteria. Somehow the default serialisation mechanism did not work for the Criteria.Join object; no idea why. There is no particular reason why the joins are initialized as null and not as empty list. If you want to change that, please go ahead. Thomas On Sun, 6 May 2007, Thomas Vandahl wrote: > tfischer@apache.org wrote: >> && asColumns.equals(criteria.getAsColumns()) >> - && joins.equals(criteria.getJoins()) >> + && ObjectUtils.equals(joins, criteria.getJoins()) > > Actually, I had a look at that code and I asked myself why the list of > joins is handled differently than all other lists in Criteria. Is there > any particular reason why this list is not initialized as empty and > declared as transient? > > > Bye, Thomas. > > --------------------------------------------------------------------- > To unsubscribe, e-mail: torque-dev-unsubscribe@db.apache.org > For additional commands, e-mail: torque-dev-help@db.apache.org > > --------------------------------------------------------------------- To unsubscribe, e-mail: torque-dev-unsubscribe@db.apache.org For additional commands, e-mail: torque-dev-help@db.apache.org